On 4/28/2015 10:13 AM, Ed W wrote: > Hi Tom > >> Here is a lightly-tested patch against the current master branch. > > Thanks for looking at this. My timings to run your patched version drop > from around 2 seconds to: > > $ time /var/lib/shorewall/firewall enable ppp0 > Device "wlan2" does not exist. > Cannot find device "wlan2" > Device "wlan3" does not exist. > Cannot find device "wlan3" > Device "lan4" does not exist. > Cannot find device "lan4" > Device "lan3" does not exist. > Cannot find device "lan3" > real 0m 0.99s > user 0m 0.21s > sys 0m 0.50s > > This is a big improvement, but I wonder if you would be willing to also > wrap the other parts of the detect_configuration tests with a conditional? >
I had already noticed that there was room for improvement and created a fix. I just pushed 864dba2..0abd51c to Sourceforge. It is against 4.6.9-Beta3. -Tom -- Tom Tom Eastep http://www.shorewall.net
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
