On 5/29/2015 1:31 PM, Steven Jan Springl wrote: > On Thu, 28 May 2015 08:32:57 -0700 > Tom Eastep <[email protected]> wrote: > > Tom > > The attached minimal config. produces the following error messages: > > Use of uninitialized value $queue in string eq > at /usr/share/shorewall/Shorewall/Rules.pm line 483, <$currentfile> > line 5. > > Use of uninitialized value $queue in split > at /usr/share/shorewall/Shorewall/Rules.pm line 489, <$currentfile> > line 5. > > Use of uninitialized value $_[0] in lc > at /usr/share/shorewall/Shorewall/Config.pm line 1401, <$currentfile> > line 5. > > Use of uninitialized value $queue1 in concatenation (.) or > string at /usr/share/shorewall/Shorewall/Rules.pm line 494, > <$currentfile> line 5. > > ERROR: Invalid NFQUEUE queue number > () /etc/shorewall201/macro.ALLOW (line 5) > > from /etc/shorewall201/rules (line 22) > Interesting -- this is a very old bug. Patch attached.
Thanks Steven, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Chains.pm
b/Shorewall/Perl/Shorewall/Chains.pm
index 56c70f4..c623068 100644
--- a/Shorewall/Perl/Shorewall/Chains.pm
+++ b/Shorewall/Perl/Shorewall/Chains.pm
@@ -8735,7 +8735,7 @@ sub get_inline_matches( $ ) {
# Split the passed target into the basic target and parameter
#
sub get_target_param( $ ) {
- my ( $target, $param ) = split '/', $_[0];
+ my ( $target, $param ) = split '/', $_[0], 2;
unless ( defined $param ) {
( $target, $param ) = ( $1, $2 ) if $target =~ /^(.*?)[(](.*)[)]$/;
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
