-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 11/02/2016 03:03 PM, Steven Jan Springl wrote:
> Tom
> 
> Snat rule:
> 
> SNAT+(:)      10.1.2.0/24     eth0    tcp
> 
> Generates iptables-restore rule:
> 
> -A SHOREWALL -o eth0 -p 6 -s 10.1.2.0/24 -j SNAT --to-source :
> 
> Which produces error message:
> 
> iptables-restore v1.4.21: Port `' not valid
> 

Steven,

The attached patch flags this case.

Thanks,
- -Tom
- -- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: GPGTools - http://gpgtools.org

iQIcBAEBCAAGBQJYGmgqAAoJEJbms/JCOk0Q/AQQALb1yx3OCmiRrgh3zwgnyzOb
qNzW+fQ7gutHHv8lPuXCEAcKxMdGiJMcxKxm115ATEJSl94KWGaYIkusDSaKhsRf
5o7ageR11nASVce4i1aM1wfAiclsIIT8bCPdO5+0sTncBiQg37xpL0JanykokJC4
LkrCV1VyxoUPGHkzl53BmTthyXufgF6bLg2hj9cCjG/fk1z3ty0wUnL5ztu1598Z
zDFEzfAYhg3oK0fJNtVamqK96iq8AUZqUWnX+d4/4kh2vTXWYMphybBqwq6Vvj83
9S9zF702i+q/YUWHhEmLZf7bnFNO4/NWcXz9zNGFYkOXjQLxuSl+DkmF8w2sHUnJ
lOA63R4DYdS5iNmVTB8zTMUE0m7FgrbZiNV/iWFv2c3snVrzFfymMBdM7O7kwTAy
CmVZXJPfPg86tPcJysiKabAQe3NcTDoay6pPBgopZkVCssJd0mwXxMxaFMNGKqN1
hnCi6XRh5uKpaJCCgITAfOVt/Zn/C6mUPmXefk43JM8Fce8oZKTwtZLeXyNdpPjL
YSquMu0JRvMJ5ixL8RvAQb+EdmMld7LVGpoce6KeWZT7ER71uhJCfcABD+ILGYJz
SUSamYoFV+PElUEQmW7cTdO1d6Nx4iv69VRyQWibEcp1GIPKrMUAhhNTp9pGe2Ti
cK+q0pLvOJb65gNTtJw+
=wWJf
-----END PGP SIGNATURE-----
diff --git a/Shorewall/Perl/Shorewall/Rules.pm b/Shorewall/Perl/Shorewall/Rules.pm
index b02836b..d92ab91 100644
--- a/Shorewall/Perl/Shorewall/Rules.pm
+++ b/Shorewall/Perl/Shorewall/Rules.pm
@@ -5573,6 +5573,7 @@ sub process_snat1( $$$$$$$$$$$$ ) {
 			} else {
 			    my $ports = $addr;
 			    $ports =~ s/^://;
+			    fatal_error "Missing Address or Port[-range] ($addr)" unless supplied $ports && $ports ne '-';
 			    validate_portpair1( $proto, $ports );
 			    $addrlist .= " --to-source :$ports";
 			    $exceptionrule = do_proto( $proto, '', '' );
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to