Karel Hudaň wrote:
> Hello everybody.
>
> Facts:
> shorewall -3.2.8-1.fc6 shiped with Fedora 6 in Extras repository
> Params:
> BF=some IP
> Rules:
> SSH/ACCEPT net:BF fw
>
> I forgot add '$' before 'BF' param and used 'make'. But no error was
> reported!!!!!!!! Restart failed silently, shorewall used restore
> informations. And missing information is the problem.
> If I used: shorewall restart; echo "Return value: $?":
> ..Expanding Macro /usr/share/shorewall/macro.SSH...
> ERROR: Unknown interface BF in rule: "ACCEPT net:BF fw tcp 22 - - - -"
> /sbin/shorewall: line 786: 5051 Terminated $SHOREWALL_SHELL
> ${SHAREDIR}/compiler $debugging $nolock compile ${VARDIR}/.restart
> Return value: 0
>
> This is the reason why make reports no problem. I am attaching trace report
> and hope it is possible to fix the problem. :)Please try the attached patch against /sbin/shorewall. The patch applies cleanly against 3.2.8 as released from shorewall.net. -Tom -- Tom Eastep \ Nothing is foolproof to a sufficiently talented fool Shoreline, \ http://shorewall.net Washington USA \ [EMAIL PROTECTED] PGP Public Key \ https://lists.shorewall.net/teastep.pgp.key
Index: shorewall
===================================================================
--- shorewall (revision 5400)
+++ shorewall (working copy)
@@ -852,8 +852,8 @@
$SHOREWALL_SHELL ${VARDIR}/.restart $debugging restart
rc=$?
else
+ rc=$?
logger -p kern.err "ERROR:Shorewall restart failed"
- rc=$?
fi
[ -n "$nolock" ] || mutex_off
@@ -919,7 +919,11 @@
$SHOREWALL_SHELL ${VARDIR}/.refresh $debugging refresh
fi
+ rc=$?
+
[ -n "$nolock" ] || mutex_off
+
+ return $rc
}
#
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________ Shorewall-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-users
