On 12/19/10 2:02 PM, Steven Jan Springl wrote: > On Sunday 19 December 2010 21:31:01 Tom Eastep wrote: >> Steven, >> >> This seems to fix it. >> >> Thanks! >> -Tom > > Tom > > It fixes all but the last message: > > Use of uninitialized value in numeric comparison (<=>) > at /usr/share/shorewall/Shorewall/Zones.pm line 1334. > > This message is produced in the "Optimizing ruleset.." phase.
Steven, Please find attached a patch that should correct this and some other problems. Thanks! -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Proxyarp.pm
b/Shorewall/Perl/Shorewall/Proxyarp.pm
index cac1a2e..4daa53c 100644
--- a/Shorewall/Perl/Shorewall/Proxyarp.pm
+++ b/Shorewall/Perl/Shorewall/Proxyarp.pm
@@ -125,15 +125,15 @@ sub setup_proxy_arp() {
$first_entry = 0;
}
- fatal_error "Unknown interface ($external)" unless known_interface
$external;
+ fatal_error "Unknown interface ($external)" unless known_interface
$external, 1;
fatal_error "Wildcard interface ($external) not allowed" if
$external =~ /\+$/;
$reset{$external} = 1 unless $set{$external};
- my $extphy = physical_name $external;
+ my $extphy = get_physical $external;
my $physical = '-';
if ( $interface ne '-' ) {
- fatal_error "Unknown interface ($interface)" unless
known_interface $interface;
+ fatal_error "Unknown interface ($interface)" unless
known_interface $interface, 1;
fatal_error "Wildcard interface ($interface) not allowed" if
$interface =~ /\+$/;
$physical = physical_name $interface;
$set{$interface} = 1;
diff --git a/Shorewall/Perl/Shorewall/Zones.pm
b/Shorewall/Perl/Shorewall/Zones.pm
index 46745d6..2fd980b 100644
--- a/Shorewall/Perl/Shorewall/Zones.pm
+++ b/Shorewall/Perl/Shorewall/Zones.pm
@@ -1334,7 +1334,7 @@ sub find_interfaces_by_option1( $ ) {
my $wild = 0;
for my $interface ( sort { $interfaces{$a}->{number} <=>
$interfaces{$b}->{number} }
- keys %interfaces ) {
+ ( grep $interfaces{$_}{root}, keys %interfaces ) ) {
my $interfaceref = $interfaces{$interface};
next unless defined $interfaceref->{physical};
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________ Shorewall-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-users
