On May 1, 2011, at 5:43 AM, Tom Eastep wrote:

> 
> The error is being presented on the tcclasses record, not the tcdevices 
> record. So it is in the processing of that record that the error is being 
> generated. I'm still mulling over how to fix that, but I'm leaning toward 
> requiring the hex value to be preceded by '0x', when the value doesn't start 
> with a digit.

..
>> 
>> Finally there is, what I think a bug, in the latest shorewall version:
>> 
>> eth0:1 - 10*full/100:50ms 20*full/100 1 tcp-ack
>> eth0:2 - 80*full/100 full 2
>> eth0:2:21 - 20*full/100 full 3
>> eth0:2:22 - 20*full/100 full 4
>> eth0:2:23 - 20*full/100 full 5
>> eth0:2:24 - 20*full/100 full 6
>> eth0:2:25 - 20*full/100 full 7
>> eth0:3 - 10*full/100 full 8 default
>> 
>> shorewall compile passes, but service shorewall (re)start ultimately fails 
>> with:
>> 
>> The culprit seems to be the use of "1" (when replaced with "12" for example 
>> all seems OK) - this should have been caught during the shorewall 
>> compilation.
> 
> Yes, it is the use of '1'; in that case, the compiler is not catching that 
> duplication but the kernel is.
> 

The attached patch corrects both issues. As I mentioned above, a 0x prefix is 
required if the device number is not numeric.

-Tom

Attachment: TC.patch
Description: Binary data

Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________


Attachment: PGP.sig
Description: This is a digitally signed message part

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Shorewall-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-users

Reply via email to