Hi, Tom Eastep wrote: >> Yes -- I have reproduced it. > > And I have come up with a *much* simpler patch.
Good job! I have verified that IPSET6b.patch is still working with linux kernel 3.10.49, 3.4.13 and 3.15.6! But I don't understand the patch. For me it looks like you only switched the > qt( "$ipset -N $sillyname iphash" ) test with the > qt( "$ipset -N $sillyname hash:ip family $fam") test. I don't understand why that's make the difference because these tests are connected with "||". If you have time it would be glad if you could explain why testing for "hash:ip" first fixes the problem although the two tests are OR-connected. PS: If you commit it this patch, you may want to add a missing space: > if ( qt( "$ipset -N $sillyname hash:ip family $fam") [...] ^^ -Thomas ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Shorewall-users mailing list Shorewall-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/shorewall-users