Hi,
I upgraded to the latest version and played a bit with it. Testing some
functions I found a small bug :
Shell# shorewall status -i
[...snip...]
cat: /var/lib/shorewall/*.status: No such file or directory
Interface * is Unknown
The problem is /usr/share/shorewall/lib.cli in function show_interfaces()
line 3247.
After do, there should be a safety check like :
[ -f "$f" ] || continue
As a general tip, there are a couple of nifty optimizations you can do
without breaking anything, such as :
- replace all occurences of : $( basename $foo ) with ${foo##*/}
- replace all occurences of : $( dirname $foo ) with ${foo%/*}
which are POSIX shell compliant and prevent spawing subprocesses. In your
case, there's only 3 occurences of "basename" in lib.cli but 2 of them are
in a for() loop so there could be some gain :-)
--
ObNox
------------------------------------------------------------------------------
_______________________________________________
Shorewall-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-users
