On 04/18/2016 06:22 AM, Justin Pryzby wrote: > A tcclasses entry with mark=0 causes shorewall 5.0.4 restart to terminate > abruptly, breaking connections. This is with iproute2-3.12.0-2 on an ubuntu > system. I propose that the compiler should reject this entry with a clean > error message. > > [...] > Setting up Proxy ARP... > Adding Providers... > Setting up Traffic Control... > RTNETLINK answers: Invalid argument > We have an error talking to the kernel > ERROR: Command "tc filter add dev eth0 protocol all parent 1:0 prio 276 > handle 0 fw classid 1:10" Failed > Running /sbin/iptables-restore... > IPv4 Forwarding Enabled > Terminated >
The attached patch will be included in 5.0.8. Thanks, Justin -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Tc.pm b/Shorewall/Perl/Shorewall/Tc.pm
index bb83820..e6047ca 100644
--- a/Shorewall/Perl/Shorewall/Tc.pm
+++ b/Shorewall/Perl/Shorewall/Tc.pm
@@ -674,7 +674,8 @@ sub validate_tc_class( ) {
$markval = numeric_value( $mark );
fatal_error "Invalid MARK ($markval)" unless defined $markval;
- fatal_error "Invalid Mark ($mark)" unless $markval <= $globals{TC_MAX};
+ fatal_error "Invalid Mark ($mark)" unless $markval <= $globals{TC_MAX};
+ fatal_error "MARK value must be non-zero" unless $markval;
if ( $classnumber ) {
fatal_error "Duplicate Class NUMBER ($classnumber)" if $tcref->{$classnumber};
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________ Shorewall-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-users
