On 12/18/2017 11:45 AM, Tom Eastep wrote:
> On 12/18/2017 10:11 AM, Tom Eastep wrote:
>> On 12/18/2017 08:37 AM, Alexander Stoll wrote:
>>> Hello
>>>
>>> I want to bring to your attention that at least gentoo stabilized
>>> iproute 4.14.x (4.4.0 was old stable) which obviously needs new
>>> parameters for tc command when enabled in shorewall.
>>>
>>> Are you already aware of this issue?
>>>
>>> Please refer also to this bug:
>>> https://bugs.gentoo.org/640766
>>>
>>> No progress on this bug visible...
>>>
>>
>> We were not aware of this issue, but I have reproduced it with
>> iproute2-4.13.0.
>>
> 
> Patch attached.
> 

Corrected patch.

-Tom
-- 
Tom Eastep        \   Q: What do you get when you cross a mobster with
Shoreline,         \     an international standard?
Washington, USA     \ A: Someone who makes you an offer you can't
http://shorewall.org \   understand
                      \_______________________________________________
diff --git a/Shorewall/Perl/Shorewall/Tc.pm b/Shorewall/Perl/Shorewall/Tc.pm
index 49dc7f6a4..58b0bed92 100644
--- a/Shorewall/Perl/Shorewall/Tc.pm
+++ b/Shorewall/Perl/Shorewall/Tc.pm
@@ -225,11 +225,11 @@ sub handle_in_bandwidth( $$$ ) {
     if ( have_capability 'BASIC_FILTER' ) {
 	if ( $in_rate ) {
 	    emit( "run_tc filter add dev $physical parent ffff: protocol all prio 10 basic \\",
-		  "    police mpu 64 drop rate ${in_rate}kbit burst $in_burst\n" );
+		  "    police mpu 64 rate ${in_rate}kbit burst $in_burst drop\n" );
 	} else {
 	    emit( "run_tc filter add dev $physical parent ffff: protocol all prio 10 \\",
 		  "    estimator $in_interval $in_decay basic \\",
-		  "    police drop avrate ${in_avrate}kbit\n" );
+		  "    police avrate ${in_avrate}kbit drop\n" );
 	}
     } else {
 	emit( "run_tc filter add dev $physical parent ffff: protocol all prio 10 \\" ,

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Shorewall-users mailing list
Shorewall-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shorewall-users

Reply via email to