On Sun, Jan 10, 2010 at 02:31:51PM +0100, Michael Pilgermann wrote:
> 
> ---
>  recipes/openmoko-3rdparty/pisi_0.4.9.bb |   33 
> -------------------------------
>  recipes/openmoko-3rdparty/rtmom_0.1.bb  |   29 +++++++++++++++++++++++++++
>  2 files changed, 29 insertions(+), 33 deletions(-)
>  delete mode 100644 recipes/openmoko-3rdparty/pisi_0.4.9.bb
>  create mode 100644 recipes/openmoko-3rdparty/rtmom_0.1.bb

If you really want to remove that older pisi you should do it in
separate patch (maybe 0.4.7 too?).

> +do_compile() {
> +     ${STAGING_BINDIR_NATIVE}/python ${S}/setup.py build ${D}
> +}
> +
> +do_install() {
> +     ${STAGING_BINDIR_NATIVE}/python ${S}/setup.py install ${D}
> +     rm -rf ${D}/opt/rtmom/build/
> +     rm -rf ${D}/opt/rtmom/patches/
> +}

Cannot this be done with 
inherit distutils? and those 2 rm in do_install_append?
Not sure how different it can be..

Please provide checksums.ini entries with recipes, I can generate it
here, but it would be safer if you send patch with them and I just check
I got the same..

CONFFILES_${PN} += "/home/root/.${PN}/conf"
I know its already used ie in pisi, but maybe there is better way.. or
install that file ie to /usr/share/doc/rtmom/rtmom.conf.example and show
warning/error if there is no ${HOME}/.rtmom/conf, that you need to copy
that file to your ${HOME}? I'm just thinking about other distributions
building from OE where is maybe root HOME /root or they are using
usually non-root accounts (ie angstrom).

And last small change.. I would use ${PV} in SRC_URI.. easier for new
version bump...

Thanks!

-- 
uin:136542059                jid:[email protected]
Jansa Martin                 sip:[email protected] 
JaMa                         
_______________________________________________
Shr-devel mailing list
[email protected]
http://lists.shr-project.org/mailman/listinfo/shr-devel

Reply via email to