Am Sonntag 14 Februar 2010 23:48:10 schrieb Nicola Fusaro:
> Hello
> 
> My name is Nicola Fusaro, I'm from Italy.
> I'm a developer now working on Business Intelligence.
> 
> I've done a patch to build xcb-proto and libxcb e enable the use of
> libxcb on libX11
> I hope you like it.
> 
> Nicola Fusaro
> 
That patch doesn't look nice ;)

* Removing > 20 packages does look wrong.
* You should generate patches with git format-patch
* Add a proper explanation why you are doing this. I don't know what's the 
advantage of using libxcb in libX11.
* Touch only one thing in that patch, so don't touch the python recipe.


So please send us an explanation, then we can discuss this patch.

thx
Thomas
_______________________________________________
Shr-devel mailing list
[email protected]
http://lists.shr-project.org/mailman/listinfo/shr-devel

Reply via email to