On Mon, May 31, 2010 at 12:18:17AM +0200, Patryk Benderz wrote: > [cut] > > those were just test patches, all sent in format from "git send-email" > > which is recommended and easiest way for me to send it. > IMHO, the right question is: Is this the easiest way for others to apply > and test these patches? > Of course comfort of a developer's work (you) is also very important, > but when you send patches in a mail's body, doesn't it generates > additional errors when applying this patches? I mean, I could by mistake > copy just a part of such mail's body and pipe it to `diff` which could > result in wrongly patched code. Couldn't it? > While having patch in a file, one would feed `diff` from a file-one > error generating step less.
Hi Patryk, everybody can use script like contrib/patchwork/pw-am.sh which is already in his checkout of git tree he will probably test with Problem with patches in a mail's body is usually when client setup is for netiquete ie line wrap around 80 chars. This won't happen as git send-email is designed with those issues in mind. When I cannot use patchwork to apply patch I always save whole e-mail as it is and apply it with "git am" which also works great (unless someone tries to manually do same thing as git send-email and copy&paste his patch to his favourite e-mail client with line-wrap etc.). Or call "git am path-to-my-local-imap-dir/email" but my local imap dir is owned by different user then my git trees, so additional chown/chmod is needed. Hope this helps with understanding why "git send-email" is preferred way on both sides (one who prepared patch as well as one who wants to apply it). Cheers, -- uin:136542059 jid:[email protected] Jansa Martin sip:[email protected] JaMa _______________________________________________ Shr-devel mailing list [email protected] http://lists.shr-project.org/mailman/listinfo/shr-devel
