On Wed, Apr 18, 2012 at 09:01:42AM +0200, Vaudano Luca wrote: > Hi Jansa, > > I made the corrections, it should look better.
Yes looks better, thanks! Next time please use -M param to git format-patch or send-email so it's smaller and easier to review. Cheers, > > Thanks > regards > Luca > > On Mon, Apr 16, 2012 at 11:15 AM, Martin Jansa <[email protected]> wrote: > > On Sun, Apr 15, 2012 at 07:43:40AM +0100, Vaudano Luca wrote: > >> Hello > >> > >> I had to make this change for building the shr-image. > >> In the archive > >> http://ftp.debian.org/debian/pool/main/m/mime-support/ > >> the version 3.44 is not present anymore so I updated the bb file. > > > > Weird, you shoudn't see such errors with default SHR setup, because that > > file is available on SHR mirror > > http://build.shr-project.org/sources/mime-support_3.44-1.tar.gz > > and meta-smartphone/meta-shr/classes/shr-mirrors.bbclass > > adds build.shr-project.org/sources above url to mirrors > > > >> Hope this is the correct way to do... > > > > Almost > > > > you should remove old version if there is no special reason to keep it > > you should reset PR value (just remove it as r0 is default) when PV is > > increased > > you should provide Signed-off-by line > > you should comply with commit message guidelines > > http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines > > > > I can include it in next pull request for oe-core or you can send it > > directly to oe-core ML, but if you want me to proxy it for you, > > then please fix 4 items above and resend. > > > > Cheers, > > > > -- > > Martin 'JaMa' Jansa jabber: [email protected] -- Martin 'JaMa' Jansa jabber: [email protected]
signature.asc
Description: Digital signature
_______________________________________________ Shr-devel mailing list [email protected] http://lists.shr-project.org/mailman/listinfo/shr-devel
