Greetings again. In hopes that this document gets pushed out to IETF Last Call
soon, here are a few comments that might help clear up some confusion and
inconsistency in the document.
Section 2 says a serial number is:
A 32-bit monotonically increasing ordinal which wraps
from 2^32-1 to 0.
Section 5.10, it says:
An implementation
which uses a fine granularity of time for the Serial Number might
never change the Cache Nonce.
Which is correct? The latter is not a monotonically increasing ordinal.
Section 4 says:
When the cache updates its database, it sends a Notify message to
every currently connected router.
Section 6.2 says:
The cache server SHOULD send a notify PDU with its current serial
number when the cache's serial changes
The first is mandatory, the second is advisory; they should match.
In section 5.3, there seems to be an implicit "MUST flush all data", like the
explicit one in section 5.10. It should probably be explicit here as well or,
if not, the document should say why a router might not flush when getting data
after a reset.
Section 5.10 says:
If, at
any time, either the router or the cache finds the value of the
nonces they hold disagree, they MUST completely drop the session
and the router MUST flush all data learned from that cache.
Why does the session need to be dropped? This could cause delay when
re-authenticating. Wouldn't it make more sense for the side that discovers the
problem to simply send Reset Query or Cache Reset? The same problem appears in
the first paragraph of section 10.
Section 6.1 says:
To limit the length of time a cache must keep the data necessary to
generate incremental updates, a router MUST send either a Serial
Query or a Reset Query no less frequently than once an hour. This
also acts as a keep alive at the application layer.
As the cache MAY not keep updates for more than one hour, the router
MUST have a polling interval of no greater than half an hour
Which MUST is correct? Half an hour or an hour? (And why are these MUST-level
at all? This could be simply be an operational decision.)
In section 2, "Non-authoritative Cache" is defined but is then only used once,
in section 3. Also in section 2, the definition of "cache" is not in fact a
definition. Maybe get rid of these two from section 2, and pull the term "local
cache" from section 3 here.
The repeated use of "rcynic" is confusing given that rcynic will probably have
features added in the future. None of them is really needed in order to
describe how this protocol functions.
A non-trivial editorial issue: the draft uses "commensurate" in many places
that does not match any of the definitions I can find in my dictionaries. I
*think* that the draft means "the same", but that is not clear.
--Paul Hoffman
_______________________________________________
sidr mailing list
sidr@ietf.org
https://www.ietf.org/mailman/listinfo/sidr
