Hi Joel Small changes are done. The branch has been rebase from master on https://github.com/ticapix/pulseview/tree/master-ticapix.
While I'm looking at the mipmap container, can we agree on which event to bind this action to ? I would like to keep a simple mouse action in addition of the cursor snap feature. What do you think ? The left/right double clicks are duplicating the mouse wheel actions. About the portability on mobile, tactile devices have specific gesture bindings http://qt-project.org/doc/qt-4.8/gestures-overview.html (swipe/pan/pinch) On Wed, Jul 23, 2014 at 11:01 AM, Joel Holdsworth <[email protected]> wrote: > Hi Pierre, > > Sorry for the delay in getting back to you. I've been rather busy this week. > > I tested your branch last night, and it works for me. I've written a few > comments on GitHub. There are a few things to work out. Also, before the > branch can be merged it will need to be rebased. It doesn't merge cleanly > yet. > > Thanks for working on this. It's a good start. We've needed a feature like > this for a while. > > Best Regards > Joel Holdsworth > > > > On 23/07/14 07:54, Pierre Gronlier wrote: >> >> On Mon, Jul 21, 2014 at 4:37 PM, Pierre Gronlier <[email protected]> >> wrote: >>> >>> Hello, >>> >>> I added the feature I wanted on the branch 0.2.x. >>> >>> You should find the proposed code modification here >>> >>> https://github.com/ticapix/pulseview/commit/0a0c00eb31224db4f287769fe9171cd8e83c791d >> >> >> In case it's easier than the merging the git branch from github, here >> is the proposed patch. >> >>> >>> This code add a right-click selection to automatically move the >>> cursors to the closest edge on each side of the selection on the >>> corresponding digital trace. >>> For example, on the screenshot, my selected area that I draw from >>> top-left to bottom-right, moves the cursors on the closest edge on the >>> left for D3 and closest edge on the right for D5. It allows fast >>> timing measurement between edges on different traces. >>> >>> What is the process to get it validated and pushed into the sigrok repo ? >>> >>> Thanks, >>> >>> On Fri, Jul 18, 2014 at 10:00 AM, Pierre Gronlier <[email protected]> >>> wrote: >>>> >>>> Hi, >>>> >>>> I would like to add the following feature to pulseview: >>>> - when I left click on the Viewport, I would like to access the logic >>>> data of the selected Trace and calculate the time between the last >>>> signal change to the next signal change. >>>> >>>> From the viewport mousePressEvent, how to: >>>> - know which line/trace was selected (I guess it's based on the y() >>>> pixel position of the click or maybe from the SelectableItem class >>>> from which Trace and LogicSignal inherit from ?) >>>> - know the time (I guess it's based on the x() pixel position of the >>>> click or should I expose new methods on the Ruler class ?) >>>> - access the logic data to search for my signal changes (I guess it's >>>> in LogicSignal, no ?) >>>> >>>> Any partial guidance for any of the previous points will help me. >>>> >>>> Thank you, >>>> >>>> -- >>>> Pierre Gronlier >>> >>> >>> >>> >>> -- >>> Pierre Gronlier >> >> >> >> >> >> >> >> ------------------------------------------------------------------------------ >> Want fast and easy access to all the code in your enterprise? Index and >> search up to 200,000 lines of code with a free copy of Black Duck >> Code Sight - the same software that powers the world's largest code >> search on Ohloh, the Black Duck Open Hub! Try it now. >> http://p.sf.net/sfu/bds >> >> >> >> _______________________________________________ >> sigrok-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/sigrok-devel >> > -- Pierre Gronlier ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
