Hi Marchel,
On Sat, Feb 03, 2018 at 02:14:52PM +0100, Marchel H wrote:
> Hello Sigrok team,
>
> The following driver is ready in its basic functions for release. The code
> is up2date with the latest build of libsigrok 0.5.0.
Great, thanks a lot for writing this driver! I'll be able to test this
against one or two Siglent scopes, will report back on whether there
are issues or not.
Independently of that, could you please
(1) Adapt the code to use the same coding style as the rest of the
libsigrok drivers, mainly one tab for indentation etc.
More details in HACKING. A "baseline" cleanup is sufficient, I'll
fixup any remaining smaller issues directly later on if I notice any.
(2) Rebase all your commits on top of current git master of libsigrok.
(3) Squash all "interim" WIP commits together, so that the initial pull
will consist of basically 2 items, the "siglent-sds: Initial
driver skeleton." patch and one "Initial driver implementation"
commit on top of that.
(4) If possible, also rename the driver to "siglent-sds" maybe, it
matches other drivers a bit closer (no "series" in the name).
If that's too much hassle I can do this step as well, no problem.
Thanks a lot!
Cheers, Uwe.
--
http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
