Hi, On Sat, Apr 21, 2018 at 08:36:30AM +0200, JR developer wrote: > To be able to analyse also other IR signals I have developed 3 generic > IR decoders
Great, thanks a lot! > Or should I post it somewhere else to get it incorporated in the standatd > sigrok decoder set? It would be easier if you could create a Github account, clone the sigrok repos there (from https://github.com/sigrokproject), commit your changes there and then let us know the URL to your repositories so that we can use git to pull directly from there. (this is not strictly necessary, just nicer; if it's too much work we can use patches on the mailing list as well). As for the decoder and files, thanks for adding those! That's great stuff! Here's a few minor comments for improvements and consistency changes so that the PDs match the rest of the decoders in libsigrokdecode: - Always use ' instead of " for all strings (consistency). - Please put some more spaces around operators (consistency): Ex: "self.sectnr==1" -> "self.sectnr == 1" Ex: "bytes=int((bits-0.5)/4)+1" -> "bytes = int((bits - 0.5) / 4) + 1" and so on... - There's trailing whitespace here and there, can be dropped (consistency). - Drop all print() calls please, no PD in mainline should use print(). That's the most important stuff I've seen upon a quick glance, once those are fixed I can take care of the remaining minor stuff. We have a sigrok-dumps repository where you can place your example files (with .sr extension and a small README please), see other files in that repo for examples. There's also a sigrok-test repo where we collect regression tests for all protocol decoders (they run against the files in sigrok-dumps). Please feel free to add a few test-cases there as well if you have the time (not strictly required, someone else will add them later if they're missing for now). Please join us on IRC (#sigrok on FreeNode) if there are any questions! Cheers, Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
