Hi, On Fri, Mar 29, 2019 at 03:40:44PM +0100, Nico wrote: > My new Korad sends a different string. Instead of "KORADKA3005PV2.0" > or "KORADKA3005PV2.0\x01" it is "KORADKA3005PV2.0\xBC". > > Instead of adding a new version, I'm using a strncmp instead.
Thanks for the patch! There was a similar one for this recently, see https://sigrok.org/gitweb/?p=libsigrok.git;a=commitdiff;h=1c0e1baaaaf0314f49470fb49a4f5e6ddc0ba1a1 Please test if that works fine for your device as well. We've had a quick discussion about the approach on IRC, we can't guarantee that there aren't any other (valid) suffixes for those strings, hence why we'd rather avoid the strncmp() method. Also, having an explicit list in the driver gives us a nice overview of which device strings actually exist out there. Cheers, Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
