Thank you very much, Gerhard :) SUMP on JTAGULATOR should be good to go now!
I hope you don't mind me asking: will the next successful build of https://sigrok.org/jenkins/job/sigrok-cross-mingw/ integrate those changes? I can't tell if that jenkins job uses the most recent git commit of libserialport or the most recent release. I'm relying on jenkins to see what the result will be on windows because building windows is broken without prior access to the missing event abstraction libusb branch artifacts (which I do not have unfortunately) [ https://sigrok.org/bugzilla/show_bug.cgi?id=1593] Best Regards, Ben Gardiner On Mon, Sep 28, 2020 at 12:22 PM Gerhard Sittig <gerhard.sit...@gmx.net> wrote: > On Thu, 2020-09-24 at 08:51 -0400, Ben Gardiner wrote: > > > > The comment and code are out of sync. The comments say "leave control > > lines alone on close." The HUPCL bit, when set, will "Lower modem control > > lines after last process closes the device (hang up)." > > > > To match the intent captured in the comment, the HUPCL bit should be > > cleared. > > Merged in 1b011060df55, thank you. > > > virtually yours > Gerhard Sittig > -- > If you don't understand or are scared by any of the above > ask your parents or an adult to help you. > > > _______________________________________________ > sigrok-devel mailing list > sigrok-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/sigrok-devel >
_______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
