We actually changed from this behaviour because it was confusing when you had 
multi-page scans (bug 1480605). So I think it makes sense to save to PDF by 
default to be less confusing. However we should definitely remember the setting 
if the user changes it. This would ideally also persist between runs (i.e. 
store in gsettings).

Diff comments:

> === modified file 'src/ui.vala'
> --- src/ui.vala       2017-03-29 09:40:01 +0000
> +++ src/ui.vala       2017-04-10 14:26:17 +0000
> @@ -507,9 +508,12 @@
>          if (book_uri != null)
>              save_dialog.set_uri (book_uri);
>          else {
> +            var filename = _("Scanned Document") + save_dialog_extension;
> +
>              save_dialog.set_current_folder (directory);
>              /* Default filename to use when saving document */

The comment should be moved to above the translated string - this is here so it 
gets pulled into the .pot file for the translators.

> -            save_dialog.set_current_name (_("Scanned Document.pdf"));
> +            debug ("Setting filename to '%s'", filename);
> +            save_dialog.set_current_name (filename);
>          }
>  
>          /* Filter to only show images by default */


-- 
https://code.launchpad.net/~mbarnes.redhat/simple-scan/default-save-format/+merge/322293
Your team Simple Scan Development Team is subscribed to branch lp:simple-scan.

_______________________________________________
Mailing list: https://launchpad.net/~simple-scan-team
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~simple-scan-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to