Well, I got it working with this. Looks like you backed up to the last
non-white-space character, and then over-write that last valid character with
the ','. So I just bump it forward one. Low tech answer, I know ;)
t
[EMAIL PROTECTED] sipp-2.0]# diff -BruN call.cpp call.new
--- call.cpp 2007-04-26 10:45:51.000000000 -0400
+++ call.new 2007-05-01 17:05:20.124298275 -0400
@@ -1179,7 +1179,7 @@
((*dest == ' ') || (*dest == '\r')|| (*dest == '\t'))) {
*(dest--) = 0;
}
-
+ dest++;
dest += sprintf(dest, ",");
/* We only want to append the contents of the header, not its name for
> Sorry Charles, I misread my email, and thought Olivier sent that patch.
>
> That patch apparently made it in the 2.0 code base, and I believe is
> causing my issue. It looks like it's backing up one character too
> far when deleting the CRLF and excess whitespace.
>
> I just tried commenting out this block:
> while ((dest > last_header) &&
> ((*dest == ' ') || (*dest == '\r')|| (*dest == '\t'))) {
> *(dest--) = 0;
> }
>
> But it retained the CRLF, so that was no better ;)
>
>
> t
>
>> Tarek,
>>
>> I believe it was the short form header patch that I posted that broke
>> this. Another user had the same issue and I sent them this patch, but
>> never got any feedback. Does this fix the issue for you?
>>
>> Charles
>>
>>
>>
>> [EMAIL PROTECTED] wrote on 05/01/2007 03:38:56 PM:
>>
>>>
>>> Hi, I've recently migrated to SIPp 2.0 (official) and have observed
>>> the following issue. The 200 response, which is built using
>>> [last_via], when the Via contains multiple headers, is bring
>>> truncated by a single character when re-built.
>>>
>>> Here's the trace - notice the first branch= tag is missing the final
>> digit.
>>>
>>> Olivier, you sent a patch out just a day or two before 2.0 was
>>> pulled regarding last_via... perhaps some breakage ?
>>>
>>> (I was previously using the Dec 08 build, so its possible this has
>>> been broken a while, but the last_via patch seems a good candidate)
>>>
>>> t
>>>
>>>
>>> NOTIFY sip:[EMAIL PROTECTED]:5060;transport=tcp SIP/2.0^M
>>> Via: SIP/2.0/TCP 67.1.100.81:5060;
>>> branch=z9hG4bK7c957453-37910fda-4fe40904-5a984882-1^M
>>> Record-Route: <sip:user-01-000001.
>>>
>> [EMAIL PROTECTED]:5060;maddr=67.1.100.81;lr>^M
>>> From: <sip:[EMAIL PROTECTED]>;tag=da5472e4^M
>>> To: <sip:[EMAIL PROTECTED]>;tag=193961-3^M
>>> CSeq: 1073741824 NOTIFY^M
>>> Call-ID: 3-///[EMAIL PROTECTED]
>>> Event: presence^M
>>> User-Agent: Cisco-PE/6.0.1.1^M
>>> Contact: <sip:67.1.100.81:5070;transport=tcp>^M
>>> Content-Length: 7624^M
>>> Content-Type: multipart/related;type="application/rlmi+xml";
>>> start="<[EMAIL PROTECTED]>";boundary="da56a10e-1dd1-11b2-b"^M
>>> Require: eventlist^M
>>> Subscription-State: active;expires=86400^M
>>> Via: SIP/2.0/TCP 67.1.100.81:5070;received=67.1.100.81;
>>> branch=z9hG4bKda5740be-1dd1-11b2-b908-83397ec92f4f^M
>>> Max-Forwards: 68^M
>>>
>>>
>>> SIP/2.0 200 OK^M
>>> Via: SIP/2.0/TCP 67.1.100.81:5060;
>>> branch=z9hG4bK7c957453-37910fda-4fe40904-5a984882-, SIP/2.0/TCP 67.
>>> 1.100.81:5070;received=67.1.100.81;branch=z9hG4bKda5740be-1dd1-11b2-
>>> b908-83397ec92f4f^M
>>> From: <sip:[EMAIL PROTECTED]>;tag=da5472e4^M
>>> To: <sip:[EMAIL PROTECTED]>;tag=193961-3^M
>>> Call-ID: 3-///[EMAIL PROTECTED]
>>> CSeq: 1073741824 NOTIFY^M
>>> Contact: <sip:67.1.100.70:5060;transport=TCP>^M
>>> Content-Length: 0^M
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Sipp-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/sipp-users
------------------------------------------------------------------------
tarogers : dc -e '[dO%O+3E%O+PO/d0<0]Fi22os036E90479868350411AD871l0xAP'
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Sipp-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sipp-users
