I'll be the first to admit that the "typing" is a mess, especially in
the mediaLib. The root is that some low level functions actually use
reference to size_t and we were passing ints into these functions,
causing crashes on 64bit platforms where int is not the same size as
size_t. When first cleaning these up I did not know about ssize_t,
which would be the appropriate replacement for (signed) int. I will
have another go at the files in mediaLib, where it looks like many
places which now have size_t should be ssize_t so that checks for < 0
still work. (Given that we still have so many compiler warnings, I
wonder why these lines of code don't generate a warning? it would
actually be useful!)
Carolyn
________________________________
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
[EMAIL PROTECTED]
Sent: Tuesday, May 13, 2008 4:24 PM
To: [EMAIL PROTECTED]
Subject: sipXecs 12633 mardy: Revert change of deliverData()
iLength argument from type 'int' to type 'size_t'.
Project sipXecs
New Revision 12633
<http://sipxecs.sipfoundry.org/ViewVC/sipXecs?view=rev&rev=12633>
Committer mardy (Marden Marshall)
Date 2008-05-13 16:24:03 -0400 (Tue, 13 May 2008)
Log
Revert change of deliverData() iLength argument from type 'int'
to type 'size_t'.
This change was preventing the notification of stream read
completion, as
indicated by a read length of '-1', from being detected.
(XECS-1405)
Modified:
* main/sipXmediaLib/include/mp/StreamHttpDataSource.h
<http://sipxecs.sipfoundry.org/ViewVC/sipXecs/main/sipXmediaLib/include/
mp/StreamHttpDataSource.h?r1=12632&r2=12633&diff_format=l>
* main/sipXmediaLib/src/mp/StreamHttpDataSource.cpp
<http://sipxecs.sipfoundry.org/ViewVC/sipXecs/main/sipXmediaLib/src/mp/S
treamHttpDataSource.cpp?r1=12632&r2=12633&diff_format=l>
_______________________________________________
sipx-dev mailing list
[email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
