Mircea Carasel wrote: > Hi, > First of all thanks a lot Kevin for your review. > I would like to share on the list some comments and explanations > regarding the implementation of this feature, based on your comments: > > 1) - When backup is performed it is uploaded on the ftp server on the > location that is exposed by the supplied ftp username/password. > Depending on what username/password is provided by accessing the > Backup/Restore Ftp Configuration page the backups will be uploaded in > that location. > For instance the administrator can configure the FTP server with how > many user he wants - each user having therefore a coresponding uploading > location > The location that is specified in the sipxconfig.properties - ftpBackup > - is used in the ftp backup process like this: > First the files are temporary saved on local sistem in the ftpBackup > directory (located in the same path as the "backup" directory -> > /usr/local/sipx/var/sipxdata) > and then are uploaded on the ftp server in the location exposed by the > username/password provided in the FTP Backup/Restore Configuration page > When the user issues another ftp backup operation the previous temporary > savings are deleted
How does that work if more that one person performs FTP backup? That's probably not very likely and I am not sure if it worked even before your changes. I guess - what I am trying to say here is: I would just create those backup file in temp directory and remove them after ftp is finished with transfer. Even if that means not displaying the links for download. But let's see how users react before we start changing that. > > So my opinion is that in fact the sipXconfig should not be aware of the > remote ftp path where the backup is uploaded - this path is > automatically exposed with the FTP connection, depending on the > username/password supplied. So the administrator should configure the > FTP server itself with what users he wants - with what paths he desires. > In this way the Backup/Restore is easy to handle - we can have one ftp > server with many users and therefore many remote ftp upload paths. > We can pick any path we want just by providing the coresponding > username/password I think I am with Mircea on that. > > > 2) The links that appear on the page after the ftp backup is completed > exposes the temporary backups located on local system (in the ftpBackup > directory described above) - so the user to immediately download them if > he wants. Of course the user will find them also uploaded in the > specified ftp server in the remote location defined by the provided > username/password I guess it does not hurt to display them. We need a nicer UI for this page sooner or later. Something that does not block while preparing the backup. > > Fell free to add any comments/suggestions. > Thanks, > Mircea > _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
