Of course I only noticed this e-mail after committing initial version...
Dale Worley wrote:
> On Fri, 2008-06-27 at 12:54 -0400, Damian Krzeminski wrote:
> diff --git a/sipXconfig/web/bin/create-ssl-truststore.sh.in
> b/sipXconfig/web/bin/create-ssl-truststore.sh.in
> index a6106f1..b4cd422 100644
> --- a/sipXconfig/web/bin/create-ssl-truststore.sh.in
> +++ b/sipXconfig/web/bin/create-ssl-truststore.sh.in
> @@ -86,7 +92,7 @@ if [ "${Action}" = "CHECKSUM" ]; then
> else
> MD5SUM=md5sum
> fi
> - Checksum=`cat $Certificates | $MD5SUM | awk '{print $1}'`
> + Checksum=`find $CaPath -type f -name \*cr[lt] | xargs -I F
> cat "F" | $MD5SUM | awk '{print $1}'`
>
> You should quote the -name argument into:
>
> find $CaPath -type f -name '*cr[lt]'
[...]
Makes sense.
>
> BTW, don't you mean '*.cr[lt]'?
Yes. That's what I mean. I changed it.
>
> How does the changed script reject non-option arguments (e.g., if
> someone writes "create-ssl-truststore.sh foo.crt")? It looks like
> they're just ignored. Worse, "create-ssl-truststore-sh --checksum xxx
> yyy --truststore zzz" will have "yyy" entirely ignored, but both options
> processed as expected.
I changed -*) to *) to match unknown options.
>
> The usage message still shows providing individual certificate file
> names.
>
> + Checksum=`find $CaPath -type f -name \*cr[lt] | xargs -I F cat "F" |
> $MD5SUM | awk '{print $1}'`
>
> Shouldn't 'xargs -I F cat "F"' be 'xargs @[EMAIL PROTECTED] cat "F"'?
> IIRC, you can't depend on xargs supporting -I.
>
I use @XARGS_REPLACE@ (indirectly) now.
All changes here:
http://sipxecs.sipfoundry.org/ViewVC/sipXecs?view=rev&rev=12997
Thanks again.
D.
_______________________________________________
sipx-dev mailing list
[email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
