Crucible reports that "This review could not be found in this instance of Crucible." for http://code.sipfoundry.org/cru/XECS-39 - but it should exist, Dale commented on it (below) - rather scary Crucible bug if reviews go missing!
Carolyn > -----Original Message----- > From: Worley, Dale (BL60:9D30) > Sent: Tuesday, August 25, 2009 3:08 PM > To: Beeton, Carolyn (CAR:9D60) > Subject: [XECS-39] Comment: XX-6349 make > SipPersistentSubscriptionMgr::updateVersion use eventTypeKey > for the subscription > > > XECS-39 commented(see http://code.sipfoundry.org/cru/XECS-39#c128 ):- > > I've thought some more about the eventType/eventTypeKey > situation. It appears that re-SUBSCRIBEs must carry the same > Event header (including parameters) as the original SUSCRIBE, > which means that we can match subscriptions based on > call-id/eventTypeKey/event-id-parameter, rather than > call-id/eventType/event-id-parameter that is officially > defined. In addition, I updated the comment on > SipSubscribeServerEventHandler::getKeys to clarify that > eventTypeKey must look like an event name with optional > parameters -- this has always been required by the code, but > has never been stated. Given those considerations, the > concerns I had about this revision are satisfied. > > --- > > ID: XECS-39 http://code.sipfoundry.org/cru/XECS-39/review > > Title: XX-6349 make > SipPersistentSubscriptionMgr::updateVersion use eventTypeKey > for the subscription > > Statement of Objectives: > Currently SipPersistentSubscriptionMgr::updateDialogInfo uses > the eventTypeKey for the subscription, which is returned by > SipSubscriptionMgr. However, > SipPersistentSubscriptionMgr::updateVersion just picks the > eventType out of the NOTIFY message. eventType is not the > same as eventTypeKey and in particular, they are not the same > for 'dialog;sla' subscriptions. > > The changes involve making > SipSubscriptionMgr::updateNotifyVersion return the > eventTypeKey for the subscription (as well as the version), > and then passing this to SipPersistentSubscriptionMgr::updateVersion. > > State: Review > > Author: Carolyn Beeton > Moderator: Carolyn Beeton > Reviewers: (1 active, 0 completed*) > Dale Worley > > > > _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
