Paul Mossman wrote: > Hi all, > > I just merged a new sipXconfig Admin and User portal layout (and > graphics) from branches/user_mdasilva_skin into main. (XX-7253, > revision 17532.) > > These are major changes, so there are surely issues yet to be > discovered. Also, a number of manual merges were required, so some > recent changes may have been lost.
What do you mean? How are we supposed to recover that? > > If you find an obvious Usability issue, search JIRA for an existing > issue. If you can't find one please raise it with Component > "Usability". Some that have already been found: > - http://track.sipfoundry.org/browse/XX-7268: Short setting labels > should not be wrapped > - http://track.sipfoundry.org/browse/XX-7269: User Portal - > Distribution List has text overflow > - http://track.sipfoundry.org/browse/XX-7270: Cannot highlight a > pre-populated User ID on the Login page > - http://track.sipfoundry.org/browse/XX-7272: Quick Tip boxes should > have singular title > - http://track.sipfoundry.org/browse/XX-7273: Devices -> Discover > Devices screen has "[TITLE]" > - http://track.sipfoundry.org/browse/XX-7274: System -> Servers -> > <server> -> Media Services screen has "[TITLE]", and needs whitespace > > For other non-Usability or non-obvious items please discuss on the list > first, like you normally would. > > Note also that the new content has (not surprizingly) affected a great > number of sipXconfig UI unit tests. These must be fixed (see > http://track.sipfoundry.org/browse/XX-7271: Fix UI Unit Tests broken by > XX-7253.) For a (hopefully *very* short) period of time the UI unit > tests have been disabled. (Revision 17533.) Paul: We never had to disable *all* UI tests in sipXconfig before. I actually delayed Tapestry upgrade once for the sole purpose of getting the UI test corrected. And we made 3 or 4 quite significant changes to the skin before: again without disabling all UI tests. As far as I can see each and every UI tests is broken now - this is not acceptable. How do you know if your merge was correct and if you did not break something? More importantly: how do you expect people to fix issues and accept patches if they cannot be verified by running a full test suite? Unit tests - and that includes UI unit tests is what make sure that nothing gets broken when changes are made. This is exactly what allows sipXconfig to have a high code churn and remain usable. Please compare how many lines of code and how many issues are changed in sipXconfig compared to other projects and you'll understand why unit tests are vital for this project. I am going to roll back the changes. Please make a branch based on your commit and get the tests fixed (and hopefully other issues fixed) and then re-merge it to main. As you say: this is quite a significant change. It would be good if you asked more experienced sipXconfig contributor to review the patch before committing it again. Damian PS: Case in point - I cannot even start sipXconfig now: [ +/- ] Exception: Missing context resource '/WEB-INF/common/Dropdown.script'. I am pretty sure UI tests would have caught it. D. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
