Hello, On 9/9/06, Kenichi Aramaki <[EMAIL PROTECTED]> wrote: > Though MpCodec_setGain() looks like to expect a value from 1 to 10 > which is described in CpMediaInterfaceFactoryImpl.h, > sipxAudioSetGain() passes 100 scale value to MpCodec_setGain(). > Since 10 scale is rough, how about changing to 100 scale? > (why they starts with 1, not 0?) > > These are several magic numbers (like 1.0f, 9.0f) in MpCodec_setGain(), > they should be symbols. If we use float conversion (As dwMaximum is > typically 0xFFFF, I think it is not essential) the correspond code can be > as follows; I've looked through the code and it looks like you've described. Does setGain work with changes you provided, or there are more work to be done? If it works, I'll commit it tomorrow.
Regards, Alexander Chemeris. _______________________________________________ sipxtapi-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/
