Hello,
On 3/7/07, Carsten Avenhaus <[EMAIL PROTECTED]> wrote: > This patch was written by Paul Yago, who has since left > our company, but gave me permission to post it. If you want your patches to be checked in to project main source tree you should be more careful. E.g.: 1) Do not mix several changes in one patch. You've mixed G.729 patch with patch, adding 'nSpecifiedLocalPort' parameter to CpPhoneMediaInterface::createConnection(), and other junk. 2) Do not put comments like this: // pcy, added optional local port parameter. // adomo PCY // pcy : adomo - encase these in directives. // adomo:pcy - temporary, use directives Comments should clearly state why this code is here, and what it does (in complicated cases). It is not interesting generaly who write this exact line. 3) Regard coding style in all its appearances. If you change coding style of some part of cde, send it as separate patch, please. -- Regards, Alexander Chemeris. SIPez LLC. SIP VoIP, IM and Presence Consulting http://www.SIPez.com tel: +1 (617) 273-4000 _______________________________________________ sipxtapi-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/
