Hi Jaroslav: Thank you for the fix. We had just noticed that the sipXtapi tests were broken last night and had not had a chance to debug yet.
Cheers, Dan --- "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: ... > Alexander, please replace in SipConnection.cpp: > > if (mpMediaInterface->isConnectionIdValid(mConnectionId) && > mpMediaInterface != NULL) > > with > > if (mpMediaInterface != NULL && > !mpMediaInterface->isConnectionIdValid(mConnectionId)) > > The original condition was very stupid, as if mpMediaInterface was > NULL > then we got > illegal memory access. Also note that in the 2nd version there is ! > before the 2nd condition. > We need to create media connection if the ID is invalid, not vice > versa. > > This bug was introduced in revision 9049. > > I didnt debug this, I just checked out revisions until I found this > one > which looked suspicios. > > Jaroslav Libak SIPez LLC SIP VoIP, IM and Presence Consulting http://www.sipez.com tel: +1 (617) 273-4000 _______________________________________________ sipxtapi-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/
