Hello,
I have some doubts about the correctness of use of assert() in various
places of MpTopologyGraph.cpp (rev. 9176). More specifically, if the
standard mechanics of assert() weren't changed by re-defining the
macro, using the expressions like:
assert(addResource(*fromFile) == OS_SUCCESS);
will cause that addResource() will never be called in Release builds,
because assert() is then defined as:
#define assert(exp) ((void)0)
I didn't check whether assert() was redefined or not here,
nevertheless IMHO such expressions should be forbidden in the code, as
they teach a dangerous habit.
Something like that:
if (addResource(*fromFile) != OS_SUCCESS)
assert(!"Something is rotten in the land of addResource()");
Is IMHO much better.
Best Regards,
Andrzej Ciarkowski
_______________________________________________
sipxtapi-dev mailing list
[email protected]
List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/
