The non windows message queue mimics the Windows PostMessage(), GetMessage()... API.
That's why it's very easy to replace the Windows Message Queue with the NWMQ in the SpeakerThread Of course it must be possible to use sipxportlib primitives instead. However, I have been using this NWMQ for monthes in my app, and I didn't find any problem (yet). stipus ----- Original Message ----- From: "Alexander Chemeris" <[EMAIL PROTECTED]> To: "Alexander Boreham" <[EMAIL PROTECTED]> Cc: <[email protected]> Sent: Friday, July 27, 2007 7:44 PM Subject: Re: [sipxtapi-dev] Silence on Windows Minimise / SipXmediaMpdSipxPcma::decodeIn fun ction drops RTP Packets > On 7/27/07, Alexander Boreham <[EMAIL PROTECTED]> wrote: > > I've started creating a patch file but am not sure how to handle the > > addition of new files (NonWin32Queue.cpp and NonWin32Queue.h) using 'svn > > diff' or how to make sure these are added to all the project files. As > > they're for Windows only I assume we can leave the Makefiles alone. > > One way is to 'svn add' new files and then generate diff - new files will be > included. Other way is to create archive and put new files in it as is with > full paths (e.g. "sipXportLib\src\Wnt\...cpp"). > > > The following threads are explicitly set to be highest priority: > > m_hMessageThread, m_TimerThread. Also in the changes is one that makes > > threads created through OsTaskWnt to be given highest priority. I plan to > > undo this last change but don't know if I should also undo the first two > > priority changes. Again, I'll try undoing these on Monday and just checking > > everything still works okay. I can understand these two threads needing to > > be very responsive. > > This part of patch set HIGHEST priority to ALL threads. I think it is not > necessarry at all. I would say it is horribly wrong. > > Index: sipXportLib/src/os/Wnt/OsTaskWnt.cpp > =================================================================== > --- sipXportLib/src/os/Wnt/OsTaskWnt.cpp (revision 9892) > +++ sipXportLib/src/os/Wnt/OsTaskWnt.cpp (working copy) > @@ -470,7 +470,9 @@ > // Unlike VxWorks, the priority is not an argument in the creation call, > // so we have to set it explicitly ourselves. To that end, we start > // the thread "suspended" and release it after setting its priority. > - setPriority(mPriority); > + //setPriority(mPriority); > + setPriority(THREAD_PRIORITY_HIGHEST); > + > ResumeThread(mThreadH); > return TRUE; > } > > Changes in sipXmediaLib/src/rtcp/RTCPTimer.cpp and > sipXmediaLib/src/rtcp/MsgQueue.cpp are doing strange things and seems > are not realted to sound cutting at all. Moreover they are Windows specific > and shuold not be here in generic code. > > And what is this NonWin32Queue? Why sipXportLib primitives could not be > used for this? > > -- > Regards, > Alexander Chemeris. > > SIPez LLC. > SIP VoIP, IM and Presence Consulting > http://www.SIPez.com > tel: +1 (617) 273-4000 > _______________________________________________ > sipxtapi-dev mailing list > [email protected] > List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/ > > > _______________________________________________ sipxtapi-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/
