I agree with you, but when I coded InBand DTMF, I didn't want to break existing code.
stipus ----- Original Message ----- From: "Jaroslav Libak" <[EMAIL PROTECTED]> To: "stipus" <[EMAIL PROTECTED]> Cc: <[email protected]> Sent: Tuesday, July 31, 2007 10:35 PM Subject: Re: [sipxtapi-dev] Inband DTMF revisited > stipus wrote: > > To debug problems, it's very good to know if the recognized DTMF is RFC2833 > > or InBand. Also I have seen some cases where you get both at the same > > time... So it's easy from the application to shut down RFC2833 or InBand. > > > > In my implementation, I have added a new SIPX_MEDIA_CAUSE = > > MEDIA_CAUSE_DTMF_INBAND > > > > When I get a MEDIA EVENT= MEDIA_REMOTE_DTMF, I look at the MEDIA_CAUSE > > > > It can be one of > > MEDIA_CAUSE_DTMF_START, /**< A RFC2833 DTMF tone has started */ > > > > MEDIA_CAUSE_DTMF_STOP, /**< A RFC2833 DTMF tone has stopped */ > > > > MEDIA_CAUSE_DTMF_INBAND // INBAND DTMF detected (ADDED BY STIPUS) > > > > > > I think having a separate enum for type of DTMF (RFC2833, in-band, INFO) > is better than adding a new enum to SIPX_MEDIA_CAUSE. > > Jaro > > > _______________________________________________ sipxtapi-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/
