On Thu, Nov 27, 2008 at 3:55 AM, Paul Whitfield
<[EMAIL PROTECTED]> wrote:
> Alexander Chemeris wrote:
>> Thanks for your patch, it looks correct.
>> But, could you, please, re-generate it with "svn diff <path-to-file>",
>> or, at least, use unified diff and correct diff direction (e.g.
>> run "diff -uprN <old-file> <new-file>". Also it would be great
>> if you followed formating style and didn't use spaces instead
>> of tabs. sipX is crossplatform and should looks good everywhere,
>> so tabs are prohibited.
>
> Ok I will fix it.
> The tabs must be a by-product of the diff generation or VS.
> Grrr... I hate that

It comes from VS. Check Tools->Options->Text Editor->C/C++->Tabs.
Here you can change Tab size (how many spaces one tab spans),
indent size (in spaces too). and finally set "Insert spaces" instead of
"Keep tabs".

> Here is the patch generated with
> svn diff sipXmediaLib\src\mp\codecs\plggsm\PlgGsm.c

Ok, checked in with minor changes:
to main branch -> rev.10993
to sipXtapi-3.2 branch -> rev.10996


-- 
Regards,
Alexander Chemeris.

SIPez LLC.
SIP VoIP, IM and Presence Consulting
http://www.SIPez.com
tel: +1 (617) 273-4000
_______________________________________________
sipxtapi-dev mailing list
[email protected]
List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/

Reply via email to