Paul, I too have VS2008 -- but I haven't been focusing on building with that... However, on December 4th, I committed a fix to address the vsnprintf problem you mention... I see with that patch you picked up that change.. is there some reason it doesn't work that I overlooked (I was compiling with VS2008 when I tested and committed that patch)?
http://scm.sipfoundry.org/viewvc/sipX?diff_format=l&view=rev&revision=11023 I saw the res_send.c issue today, but I've been focusing on making VS6 build working again, so I haven't had as much time to fix this... The issue seems to be that poll.h defines a lot of things that are now present in the version of winsock2.h included with VS2008. Looking at a few of those defines which have collisions -- the values that they have are not equivalent. Many are bitfield specifiers, with different bits specified. I'm not sure which one is correct in this case... Anyone have any idea? My thought is that winsock2.h's versions should be used. If that's the case, then in poll.h, we just need to wrap those defines inside an: #if defined(_MSC_VER) && (_MSC_VER < 1500) #endif Might you try that and see if it works? I'll dig around and see if I can figure out if there are unit tests that exercise these code paths. (res_send.c) On Wed, Dec 10, 2008 at 12:09 AM, Paul Whitfield <[EMAIL PROTECTED]>wrote: > When building current 3.2 and Main branches there is an issue with VS2008 > > In the module sipXtackLib, the file res_send.c includes > resparse/poll.h. This barfs VS2008 defines many of the > values in this file. > > If I comment out the file, it builds OK. > I am not sure the nicest way to fix this. > > Secondly > Checking out the current main branch there is an error > that causes the code to note #define snprintf to _snprintf. > > I have attached a patch. > > Regards > > Paul > > > > > Index: sipXportLib/include/os/OsDefs.h > =================================================================== > --- sipXportLib/include/os/OsDefs.h (revision 11073) > +++ sipXportLib/include/os/OsDefs.h (working copy) > @@ -53,10 +53,14 @@ > // Even now, with VS2008, they aren't compliant, however visual studio > // has gone about and defined vsnprintf. > // > http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=101293 > -#if<http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=101293-#if>defined(WIN32) > && defined(_MSC_VER) && (_MSC_VER < 1500) > + > +#if defined(WIN32) && defined(_MSC_VER) > # define snprintf _snprintf > + > +#if (_MSC_VER < 1500) > # define vsnprintf _vsnprintf > #endif > +#endif > > #if defined(va_copy) > #elif defined(__va_copy) > > _______________________________________________ > sipxtapi-dev mailing list > [email protected] > List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/ > -- Keith Kyzivat SIPez LLC. SIP VoIP, IM and Presence Consulting http://www.SIPez.com tel: +1 (617) 273-4000
_______________________________________________ sipxtapi-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/
