Modified: websites/production/maven/content/plugins-archives/maven-checkstyle-plugin-LATEST/xref/org/apache/maven/plugin/checkstyle/exec/DefaultCheckstyleExecutor.html ============================================================================== --- websites/production/maven/content/plugins-archives/maven-checkstyle-plugin-LATEST/xref/org/apache/maven/plugin/checkstyle/exec/DefaultCheckstyleExecutor.html (original) +++ websites/production/maven/content/plugins-archives/maven-checkstyle-plugin-LATEST/xref/org/apache/maven/plugin/checkstyle/exec/DefaultCheckstyleExecutor.html Tue Jan 27 00:57:50 2015 @@ -88,779 +88,787 @@ <a class="jxr_linenumber" name="L80" href="#L80">80</a> @Requirement( hint = <span class="jxr_string">"license"</span> ) <a class="jxr_linenumber" name="L81" href="#L81">81</a> <strong class="jxr_keyword">private</strong> ResourceManager licenseLocator; <a class="jxr_linenumber" name="L82" href="#L82">82</a> -<a class="jxr_linenumber" name="L83" href="#L83">83</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> File[] EMPTY_FILE_ARRAY = <strong class="jxr_keyword">new</strong> File[0]; -<a class="jxr_linenumber" name="L84" href="#L84">84</a> -<a class="jxr_linenumber" name="L85" href="#L85">85</a> <strong class="jxr_keyword">public</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleResults.html">CheckstyleResults</a> executeCheckstyle( CheckstyleExecutorRequest request ) -<a class="jxr_linenumber" name="L86" href="#L86">86</a> <strong class="jxr_keyword">throws</strong> CheckstyleExecutorException, CheckstyleException -<a class="jxr_linenumber" name="L87" href="#L87">87</a> { -<a class="jxr_linenumber" name="L88" href="#L88">88</a> <em class="jxr_comment">// Checkstyle will always use the context classloader in order</em> -<a class="jxr_linenumber" name="L89" href="#L89">89</a> <em class="jxr_comment">// to load resources (dtds),</em> -<a class="jxr_linenumber" name="L90" href="#L90">90</a> <em class="jxr_comment">// so we have to fix it</em> -<a class="jxr_linenumber" name="L91" href="#L91">91</a> <em class="jxr_comment">// olamy this hack is not anymore needed in Maven 3.x</em> -<a class="jxr_linenumber" name="L92" href="#L92">92</a> ClassLoader checkstyleClassLoader = PackageNamesLoader.<strong class="jxr_keyword">class</strong>.getClassLoader(); -<a class="jxr_linenumber" name="L93" href="#L93">93</a> Thread.currentThread().setContextClassLoader( checkstyleClassLoader ); -<a class="jxr_linenumber" name="L94" href="#L94">94</a> -<a class="jxr_linenumber" name="L95" href="#L95">95</a> <strong class="jxr_keyword">if</strong> ( getLogger().isDebugEnabled() ) -<a class="jxr_linenumber" name="L96" href="#L96">96</a> { -<a class="jxr_linenumber" name="L97" href="#L97">97</a> getLogger().debug( <span class="jxr_string">"executeCheckstyle start headerLocation : "</span> + request.getHeaderLocation() ); -<a class="jxr_linenumber" name="L98" href="#L98">98</a> } +<a class="jxr_linenumber" name="L83" href="#L83">83</a> <strong class="jxr_keyword">public</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleResults.html">CheckstyleResults</a> executeCheckstyle( CheckstyleExecutorRequest request ) +<a class="jxr_linenumber" name="L84" href="#L84">84</a> <strong class="jxr_keyword">throws</strong> CheckstyleExecutorException, CheckstyleException +<a class="jxr_linenumber" name="L85" href="#L85">85</a> { +<a class="jxr_linenumber" name="L86" href="#L86">86</a> <em class="jxr_comment">// Checkstyle will always use the context classloader in order</em> +<a class="jxr_linenumber" name="L87" href="#L87">87</a> <em class="jxr_comment">// to load resources (dtds),</em> +<a class="jxr_linenumber" name="L88" href="#L88">88</a> <em class="jxr_comment">// so we have to fix it</em> +<a class="jxr_linenumber" name="L89" href="#L89">89</a> <em class="jxr_comment">// olamy this hack is not anymore needed in Maven 3.x</em> +<a class="jxr_linenumber" name="L90" href="#L90">90</a> ClassLoader checkstyleClassLoader = PackageNamesLoader.<strong class="jxr_keyword">class</strong>.getClassLoader(); +<a class="jxr_linenumber" name="L91" href="#L91">91</a> Thread.currentThread().setContextClassLoader( checkstyleClassLoader ); +<a class="jxr_linenumber" name="L92" href="#L92">92</a> +<a class="jxr_linenumber" name="L93" href="#L93">93</a> <strong class="jxr_keyword">if</strong> ( getLogger().isDebugEnabled() ) +<a class="jxr_linenumber" name="L94" href="#L94">94</a> { +<a class="jxr_linenumber" name="L95" href="#L95">95</a> getLogger().debug( <span class="jxr_string">"executeCheckstyle start headerLocation : "</span> + request.getHeaderLocation() ); +<a class="jxr_linenumber" name="L96" href="#L96">96</a> } +<a class="jxr_linenumber" name="L97" href="#L97">97</a> +<a class="jxr_linenumber" name="L98" href="#L98">98</a> MavenProject project = request.getProject(); <a class="jxr_linenumber" name="L99" href="#L99">99</a> -<a class="jxr_linenumber" name="L100" href="#L100">100</a> MavenProject project = request.getProject(); -<a class="jxr_linenumber" name="L101" href="#L101">101</a> -<a class="jxr_linenumber" name="L102" href="#L102">102</a> configureResourceLocator( locator, request, <strong class="jxr_keyword">null</strong> ); -<a class="jxr_linenumber" name="L103" href="#L103">103</a> -<a class="jxr_linenumber" name="L104" href="#L104">104</a> configureResourceLocator( licenseLocator, request, request.getLicenseArtifacts() ); -<a class="jxr_linenumber" name="L105" href="#L105">105</a> -<a class="jxr_linenumber" name="L106" href="#L106">106</a> <em class="jxr_comment">// Config is less critical than License, locator can still be used.</em> -<a class="jxr_linenumber" name="L107" href="#L107">107</a> <em class="jxr_comment">// configureResourceLocator( configurationLocator, request, request.getConfigurationArtifacts() );</em> -<a class="jxr_linenumber" name="L108" href="#L108">108</a> -<a class="jxr_linenumber" name="L109" href="#L109">109</a> List<File> files; -<a class="jxr_linenumber" name="L110" href="#L110">110</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L111" href="#L111">111</a> { -<a class="jxr_linenumber" name="L112" href="#L112">112</a> files = getFilesToProcess( request ); -<a class="jxr_linenumber" name="L113" href="#L113">113</a> } -<a class="jxr_linenumber" name="L114" href="#L114">114</a> <strong class="jxr_keyword">catch</strong> ( IOException e ) -<a class="jxr_linenumber" name="L115" href="#L115">115</a> { -<a class="jxr_linenumber" name="L116" href="#L116">116</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a>( <span class="jxr_string">"Error getting files to process"</span>, e ); -<a class="jxr_linenumber" name="L117" href="#L117">117</a> } -<a class="jxr_linenumber" name="L118" href="#L118">118</a> -<a class="jxr_linenumber" name="L119" href="#L119">119</a> <strong class="jxr_keyword">final</strong> String suppressionsFilePath = getSuppressionsFilePath( request ); -<a class="jxr_linenumber" name="L120" href="#L120">120</a> FilterSet filterSet = getSuppressionsFilterSet( suppressionsFilePath ); +<a class="jxr_linenumber" name="L100" href="#L100">100</a> configureResourceLocator( locator, request, <strong class="jxr_keyword">null</strong> ); +<a class="jxr_linenumber" name="L101" href="#L101">101</a> +<a class="jxr_linenumber" name="L102" href="#L102">102</a> configureResourceLocator( licenseLocator, request, request.getLicenseArtifacts() ); +<a class="jxr_linenumber" name="L103" href="#L103">103</a> +<a class="jxr_linenumber" name="L104" href="#L104">104</a> <em class="jxr_comment">// Config is less critical than License, locator can still be used.</em> +<a class="jxr_linenumber" name="L105" href="#L105">105</a> <em class="jxr_comment">// configureResourceLocator( configurationLocator, request, request.getConfigurationArtifacts() );</em> +<a class="jxr_linenumber" name="L106" href="#L106">106</a> +<a class="jxr_linenumber" name="L107" href="#L107">107</a> List<File> files; +<a class="jxr_linenumber" name="L108" href="#L108">108</a> <strong class="jxr_keyword">try</strong> +<a class="jxr_linenumber" name="L109" href="#L109">109</a> { +<a class="jxr_linenumber" name="L110" href="#L110">110</a> files = getFilesToProcess( request ); +<a class="jxr_linenumber" name="L111" href="#L111">111</a> } +<a class="jxr_linenumber" name="L112" href="#L112">112</a> <strong class="jxr_keyword">catch</strong> ( IOException e ) +<a class="jxr_linenumber" name="L113" href="#L113">113</a> { +<a class="jxr_linenumber" name="L114" href="#L114">114</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a>( <span class="jxr_string">"Error getting files to process"</span>, e ); +<a class="jxr_linenumber" name="L115" href="#L115">115</a> } +<a class="jxr_linenumber" name="L116" href="#L116">116</a> +<a class="jxr_linenumber" name="L117" href="#L117">117</a> <strong class="jxr_keyword">final</strong> String suppressionsFilePath = getSuppressionsFilePath( request ); +<a class="jxr_linenumber" name="L118" href="#L118">118</a> FilterSet filterSet = getSuppressionsFilterSet( suppressionsFilePath ); +<a class="jxr_linenumber" name="L119" href="#L119">119</a> +<a class="jxr_linenumber" name="L120" href="#L120">120</a> Checker checker = <strong class="jxr_keyword">new</strong> Checker(); <a class="jxr_linenumber" name="L121" href="#L121">121</a> -<a class="jxr_linenumber" name="L122" href="#L122">122</a> Checker checker = <strong class="jxr_keyword">new</strong> Checker(); -<a class="jxr_linenumber" name="L123" href="#L123">123</a> -<a class="jxr_linenumber" name="L124" href="#L124">124</a> <em class="jxr_comment">// setup classloader, needed to avoid "Unable to get class information for ..." errors</em> -<a class="jxr_linenumber" name="L125" href="#L125">125</a> List<String> classPathStrings = <strong class="jxr_keyword">new</strong> ArrayList<String>(); -<a class="jxr_linenumber" name="L126" href="#L126">126</a> List<String> outputDirectories = <strong class="jxr_keyword">new</strong> ArrayList<String>(); -<a class="jxr_linenumber" name="L127" href="#L127">127</a> -<a class="jxr_linenumber" name="L128" href="#L128">128</a> <em class="jxr_comment">// stand-alone</em> -<a class="jxr_linenumber" name="L129" href="#L129">129</a> Collection<File> sourceDirectories = <strong class="jxr_keyword">null</strong>; -<a class="jxr_linenumber" name="L130" href="#L130">130</a> Collection<File> testSourceDirectories = request.getTestSourceDirectories(); -<a class="jxr_linenumber" name="L131" href="#L131">131</a> -<a class="jxr_linenumber" name="L132" href="#L132">132</a> <em class="jxr_comment">// aggregator</em> -<a class="jxr_linenumber" name="L133" href="#L133">133</a> Map<MavenProject, Collection<File>> sourceDirectoriesByProject = <strong class="jxr_keyword">new</strong> HashMap<MavenProject, Collection<File>>(); -<a class="jxr_linenumber" name="L134" href="#L134">134</a> Map<MavenProject, Collection<File>> testSourceDirectoriesByProject = <strong class="jxr_keyword">new</strong> HashMap<MavenProject, Collection<File>>(); -<a class="jxr_linenumber" name="L135" href="#L135">135</a> -<a class="jxr_linenumber" name="L136" href="#L136">136</a> <strong class="jxr_keyword">if</strong> ( request.isAggregate() ) -<a class="jxr_linenumber" name="L137" href="#L137">137</a> { -<a class="jxr_linenumber" name="L138" href="#L138">138</a> <strong class="jxr_keyword">for</strong> ( MavenProject childProject : request.getReactorProjects() ) -<a class="jxr_linenumber" name="L139" href="#L139">139</a> { -<a class="jxr_linenumber" name="L140" href="#L140">140</a> sourceDirectories = <strong class="jxr_keyword">new</strong> ArrayList<File>( childProject.getCompileSourceRoots().size() ); -<a class="jxr_linenumber" name="L141" href="#L141">141</a> List<String> compileSourceRoots = childProject.getCompileSourceRoots(); -<a class="jxr_linenumber" name="L142" href="#L142">142</a> <strong class="jxr_keyword">for</strong> ( String compileSourceRoot : compileSourceRoots ) -<a class="jxr_linenumber" name="L143" href="#L143">143</a> { -<a class="jxr_linenumber" name="L144" href="#L144">144</a> sourceDirectories.add( <strong class="jxr_keyword">new</strong> File( compileSourceRoot ) ); -<a class="jxr_linenumber" name="L145" href="#L145">145</a> } -<a class="jxr_linenumber" name="L146" href="#L146">146</a> sourceDirectoriesByProject.put( childProject, sourceDirectories ); -<a class="jxr_linenumber" name="L147" href="#L147">147</a> -<a class="jxr_linenumber" name="L148" href="#L148">148</a> testSourceDirectories = <strong class="jxr_keyword">new</strong> ArrayList<File>( childProject.getTestCompileSourceRoots().size() ); -<a class="jxr_linenumber" name="L149" href="#L149">149</a> List<String> testCompileSourceRoots = childProject.getTestCompileSourceRoots(); -<a class="jxr_linenumber" name="L150" href="#L150">150</a> <strong class="jxr_keyword">for</strong> ( String testCompileSourceRoot : testCompileSourceRoots ) -<a class="jxr_linenumber" name="L151" href="#L151">151</a> { -<a class="jxr_linenumber" name="L152" href="#L152">152</a> testSourceDirectories.add( <strong class="jxr_keyword">new</strong> File( testCompileSourceRoot ) ); -<a class="jxr_linenumber" name="L153" href="#L153">153</a> } -<a class="jxr_linenumber" name="L154" href="#L154">154</a> testSourceDirectoriesByProject.put( childProject, testSourceDirectories ); -<a class="jxr_linenumber" name="L155" href="#L155">155</a> -<a class="jxr_linenumber" name="L156" href="#L156">156</a> prepareCheckstylePaths( request, childProject, classPathStrings, outputDirectories, -<a class="jxr_linenumber" name="L157" href="#L157">157</a> sourceDirectories, testSourceDirectories ); -<a class="jxr_linenumber" name="L158" href="#L158">158</a> } -<a class="jxr_linenumber" name="L159" href="#L159">159</a> } -<a class="jxr_linenumber" name="L160" href="#L160">160</a> <strong class="jxr_keyword">else</strong> -<a class="jxr_linenumber" name="L161" href="#L161">161</a> { -<a class="jxr_linenumber" name="L162" href="#L162">162</a> sourceDirectories = request.getSourceDirectories(); -<a class="jxr_linenumber" name="L163" href="#L163">163</a> prepareCheckstylePaths( request, project, classPathStrings, outputDirectories, sourceDirectories, -<a class="jxr_linenumber" name="L164" href="#L164">164</a> testSourceDirectories ); -<a class="jxr_linenumber" name="L165" href="#L165">165</a> } -<a class="jxr_linenumber" name="L166" href="#L166">166</a> -<a class="jxr_linenumber" name="L167" href="#L167">167</a> <strong class="jxr_keyword">final</strong> List<URL> urls = <strong class="jxr_keyword">new</strong> ArrayList<URL>( classPathStrings.size() ); -<a class="jxr_linenumber" name="L168" href="#L168">168</a> -<a class="jxr_linenumber" name="L169" href="#L169">169</a> <strong class="jxr_keyword">for</strong> ( String path : classPathStrings ) -<a class="jxr_linenumber" name="L170" href="#L170">170</a> { -<a class="jxr_linenumber" name="L171" href="#L171">171</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L172" href="#L172">172</a> { -<a class="jxr_linenumber" name="L173" href="#L173">173</a> urls.add( <strong class="jxr_keyword">new</strong> File( path ).toURL() ); -<a class="jxr_linenumber" name="L174" href="#L174">174</a> } -<a class="jxr_linenumber" name="L175" href="#L175">175</a> <strong class="jxr_keyword">catch</strong> ( MalformedURLException e ) -<a class="jxr_linenumber" name="L176" href="#L176">176</a> { -<a class="jxr_linenumber" name="L177" href="#L177">177</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a>( e.getMessage(), e ); -<a class="jxr_linenumber" name="L178" href="#L178">178</a> } -<a class="jxr_linenumber" name="L179" href="#L179">179</a> } -<a class="jxr_linenumber" name="L180" href="#L180">180</a> -<a class="jxr_linenumber" name="L181" href="#L181">181</a> <strong class="jxr_keyword">for</strong> ( String outputDirectoryString : outputDirectories ) -<a class="jxr_linenumber" name="L182" href="#L182">182</a> { -<a class="jxr_linenumber" name="L183" href="#L183">183</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L184" href="#L184">184</a> { -<a class="jxr_linenumber" name="L185" href="#L185">185</a> <strong class="jxr_keyword">if</strong> ( outputDirectoryString != <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L186" href="#L186">186</a> { -<a class="jxr_linenumber" name="L187" href="#L187">187</a> File outputDirectoryFile = <strong class="jxr_keyword">new</strong> File( outputDirectoryString ); -<a class="jxr_linenumber" name="L188" href="#L188">188</a> <strong class="jxr_keyword">if</strong> ( outputDirectoryFile.exists() ) -<a class="jxr_linenumber" name="L189" href="#L189">189</a> { -<a class="jxr_linenumber" name="L190" href="#L190">190</a> URL outputDirectoryUrl = outputDirectoryFile.toURL(); -<a class="jxr_linenumber" name="L191" href="#L191">191</a> request.getLog().debug( -<a class="jxr_linenumber" name="L192" href="#L192">192</a> <span class="jxr_string">"Adding the outputDirectory "</span> + outputDirectoryUrl.toString() -<a class="jxr_linenumber" name="L193" href="#L193">193</a> + <span class="jxr_string">" to the Checkstyle class path"</span> ); -<a class="jxr_linenumber" name="L194" href="#L194">194</a> urls.add( outputDirectoryUrl ); -<a class="jxr_linenumber" name="L195" href="#L195">195</a> } -<a class="jxr_linenumber" name="L196" href="#L196">196</a> } -<a class="jxr_linenumber" name="L197" href="#L197">197</a> } -<a class="jxr_linenumber" name="L198" href="#L198">198</a> <strong class="jxr_keyword">catch</strong> ( MalformedURLException e ) -<a class="jxr_linenumber" name="L199" href="#L199">199</a> { -<a class="jxr_linenumber" name="L200" href="#L200">200</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a>( e.getMessage(), e ); -<a class="jxr_linenumber" name="L201" href="#L201">201</a> } -<a class="jxr_linenumber" name="L202" href="#L202">202</a> } -<a class="jxr_linenumber" name="L203" href="#L203">203</a> -<a class="jxr_linenumber" name="L204" href="#L204">204</a> URLClassLoader projectClassLoader = AccessController.doPrivileged( <strong class="jxr_keyword">new</strong> PrivilegedAction<URLClassLoader>() -<a class="jxr_linenumber" name="L205" href="#L205">205</a> { -<a class="jxr_linenumber" name="L206" href="#L206">206</a> <strong class="jxr_keyword">public</strong> URLClassLoader run() -<a class="jxr_linenumber" name="L207" href="#L207">207</a> { -<a class="jxr_linenumber" name="L208" href="#L208">208</a> <strong class="jxr_keyword">return</strong> <strong class="jxr_keyword">new</strong> URLClassLoader( urls.toArray( <strong class="jxr_keyword">new</strong> URL[urls.size()] ), <strong class="jxr_keyword">null</strong> ); -<a class="jxr_linenumber" name="L209" href="#L209">209</a> } -<a class="jxr_linenumber" name="L210" href="#L210">210</a> } ); +<a class="jxr_linenumber" name="L122" href="#L122">122</a> <em class="jxr_comment">// setup classloader, needed to avoid "Unable to get class information for ..." errors</em> +<a class="jxr_linenumber" name="L123" href="#L123">123</a> List<String> classPathStrings = <strong class="jxr_keyword">new</strong> ArrayList<String>(); +<a class="jxr_linenumber" name="L124" href="#L124">124</a> List<String> outputDirectories = <strong class="jxr_keyword">new</strong> ArrayList<String>(); +<a class="jxr_linenumber" name="L125" href="#L125">125</a> +<a class="jxr_linenumber" name="L126" href="#L126">126</a> <em class="jxr_comment">// stand-alone</em> +<a class="jxr_linenumber" name="L127" href="#L127">127</a> Collection<File> sourceDirectories = <strong class="jxr_keyword">null</strong>; +<a class="jxr_linenumber" name="L128" href="#L128">128</a> Collection<File> testSourceDirectories = request.getTestSourceDirectories(); +<a class="jxr_linenumber" name="L129" href="#L129">129</a> +<a class="jxr_linenumber" name="L130" href="#L130">130</a> <em class="jxr_comment">// aggregator</em> +<a class="jxr_linenumber" name="L131" href="#L131">131</a> Map<MavenProject, Collection<File>> sourceDirectoriesByProject = <strong class="jxr_keyword">new</strong> HashMap<MavenProject, Collection<File>>(); +<a class="jxr_linenumber" name="L132" href="#L132">132</a> Map<MavenProject, Collection<File>> testSourceDirectoriesByProject = +<a class="jxr_linenumber" name="L133" href="#L133">133</a> <strong class="jxr_keyword">new</strong> HashMap<MavenProject, Collection<File>>(); +<a class="jxr_linenumber" name="L134" href="#L134">134</a> +<a class="jxr_linenumber" name="L135" href="#L135">135</a> <strong class="jxr_keyword">if</strong> ( request.isAggregate() ) +<a class="jxr_linenumber" name="L136" href="#L136">136</a> { +<a class="jxr_linenumber" name="L137" href="#L137">137</a> <strong class="jxr_keyword">for</strong> ( MavenProject childProject : request.getReactorProjects() ) +<a class="jxr_linenumber" name="L138" href="#L138">138</a> { +<a class="jxr_linenumber" name="L139" href="#L139">139</a> sourceDirectories = <strong class="jxr_keyword">new</strong> ArrayList<File>( childProject.getCompileSourceRoots().size() ); +<a class="jxr_linenumber" name="L140" href="#L140">140</a> List<String> compileSourceRoots = childProject.getCompileSourceRoots(); +<a class="jxr_linenumber" name="L141" href="#L141">141</a> <strong class="jxr_keyword">for</strong> ( String compileSourceRoot : compileSourceRoots ) +<a class="jxr_linenumber" name="L142" href="#L142">142</a> { +<a class="jxr_linenumber" name="L143" href="#L143">143</a> sourceDirectories.add( <strong class="jxr_keyword">new</strong> File( compileSourceRoot ) ); +<a class="jxr_linenumber" name="L144" href="#L144">144</a> } +<a class="jxr_linenumber" name="L145" href="#L145">145</a> sourceDirectoriesByProject.put( childProject, sourceDirectories ); +<a class="jxr_linenumber" name="L146" href="#L146">146</a> +<a class="jxr_linenumber" name="L147" href="#L147">147</a> testSourceDirectories = <strong class="jxr_keyword">new</strong> ArrayList<File>( childProject.getTestCompileSourceRoots().size() ); +<a class="jxr_linenumber" name="L148" href="#L148">148</a> List<String> testCompileSourceRoots = childProject.getTestCompileSourceRoots(); +<a class="jxr_linenumber" name="L149" href="#L149">149</a> <strong class="jxr_keyword">for</strong> ( String testCompileSourceRoot : testCompileSourceRoots ) +<a class="jxr_linenumber" name="L150" href="#L150">150</a> { +<a class="jxr_linenumber" name="L151" href="#L151">151</a> testSourceDirectories.add( <strong class="jxr_keyword">new</strong> File( testCompileSourceRoot ) ); +<a class="jxr_linenumber" name="L152" href="#L152">152</a> } +<a class="jxr_linenumber" name="L153" href="#L153">153</a> testSourceDirectoriesByProject.put( childProject, testSourceDirectories ); +<a class="jxr_linenumber" name="L154" href="#L154">154</a> +<a class="jxr_linenumber" name="L155" href="#L155">155</a> prepareCheckstylePaths( request, childProject, classPathStrings, outputDirectories, +<a class="jxr_linenumber" name="L156" href="#L156">156</a> sourceDirectories, testSourceDirectories ); +<a class="jxr_linenumber" name="L157" href="#L157">157</a> } +<a class="jxr_linenumber" name="L158" href="#L158">158</a> } +<a class="jxr_linenumber" name="L159" href="#L159">159</a> <strong class="jxr_keyword">else</strong> +<a class="jxr_linenumber" name="L160" href="#L160">160</a> { +<a class="jxr_linenumber" name="L161" href="#L161">161</a> sourceDirectories = request.getSourceDirectories(); +<a class="jxr_linenumber" name="L162" href="#L162">162</a> prepareCheckstylePaths( request, project, classPathStrings, outputDirectories, sourceDirectories, +<a class="jxr_linenumber" name="L163" href="#L163">163</a> testSourceDirectories ); +<a class="jxr_linenumber" name="L164" href="#L164">164</a> } +<a class="jxr_linenumber" name="L165" href="#L165">165</a> +<a class="jxr_linenumber" name="L166" href="#L166">166</a> <strong class="jxr_keyword">final</strong> List<URL> urls = <strong class="jxr_keyword">new</strong> ArrayList<URL>( classPathStrings.size() ); +<a class="jxr_linenumber" name="L167" href="#L167">167</a> +<a class="jxr_linenumber" name="L168" href="#L168">168</a> <strong class="jxr_keyword">for</strong> ( String path : classPathStrings ) +<a class="jxr_linenumber" name="L169" href="#L169">169</a> { +<a class="jxr_linenumber" name="L170" href="#L170">170</a> <strong class="jxr_keyword">try</strong> +<a class="jxr_linenumber" name="L171" href="#L171">171</a> { +<a class="jxr_linenumber" name="L172" href="#L172">172</a> urls.add( <strong class="jxr_keyword">new</strong> File( path ).toURL() ); +<a class="jxr_linenumber" name="L173" href="#L173">173</a> } +<a class="jxr_linenumber" name="L174" href="#L174">174</a> <strong class="jxr_keyword">catch</strong> ( MalformedURLException e ) +<a class="jxr_linenumber" name="L175" href="#L175">175</a> { +<a class="jxr_linenumber" name="L176" href="#L176">176</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a>( e.getMessage(), e ); +<a class="jxr_linenumber" name="L177" href="#L177">177</a> } +<a class="jxr_linenumber" name="L178" href="#L178">178</a> } +<a class="jxr_linenumber" name="L179" href="#L179">179</a> +<a class="jxr_linenumber" name="L180" href="#L180">180</a> <strong class="jxr_keyword">for</strong> ( String outputDirectoryString : outputDirectories ) +<a class="jxr_linenumber" name="L181" href="#L181">181</a> { +<a class="jxr_linenumber" name="L182" href="#L182">182</a> <strong class="jxr_keyword">try</strong> +<a class="jxr_linenumber" name="L183" href="#L183">183</a> { +<a class="jxr_linenumber" name="L184" href="#L184">184</a> <strong class="jxr_keyword">if</strong> ( outputDirectoryString != <strong class="jxr_keyword">null</strong> ) +<a class="jxr_linenumber" name="L185" href="#L185">185</a> { +<a class="jxr_linenumber" name="L186" href="#L186">186</a> File outputDirectoryFile = <strong class="jxr_keyword">new</strong> File( outputDirectoryString ); +<a class="jxr_linenumber" name="L187" href="#L187">187</a> <strong class="jxr_keyword">if</strong> ( outputDirectoryFile.exists() ) +<a class="jxr_linenumber" name="L188" href="#L188">188</a> { +<a class="jxr_linenumber" name="L189" href="#L189">189</a> URL outputDirectoryUrl = outputDirectoryFile.toURL(); +<a class="jxr_linenumber" name="L190" href="#L190">190</a> getLogger().debug( <span class="jxr_string">"Adding the outputDirectory "</span> + outputDirectoryUrl.toString() +<a class="jxr_linenumber" name="L191" href="#L191">191</a> + <span class="jxr_string">" to the Checkstyle class path"</span> ); +<a class="jxr_linenumber" name="L192" href="#L192">192</a> urls.add( outputDirectoryUrl ); +<a class="jxr_linenumber" name="L193" href="#L193">193</a> } +<a class="jxr_linenumber" name="L194" href="#L194">194</a> } +<a class="jxr_linenumber" name="L195" href="#L195">195</a> } +<a class="jxr_linenumber" name="L196" href="#L196">196</a> <strong class="jxr_keyword">catch</strong> ( MalformedURLException e ) +<a class="jxr_linenumber" name="L197" href="#L197">197</a> { +<a class="jxr_linenumber" name="L198" href="#L198">198</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a>( e.getMessage(), e ); +<a class="jxr_linenumber" name="L199" href="#L199">199</a> } +<a class="jxr_linenumber" name="L200" href="#L200">200</a> } +<a class="jxr_linenumber" name="L201" href="#L201">201</a> +<a class="jxr_linenumber" name="L202" href="#L202">202</a> URLClassLoader projectClassLoader = AccessController.doPrivileged( <strong class="jxr_keyword">new</strong> PrivilegedAction<URLClassLoader>() +<a class="jxr_linenumber" name="L203" href="#L203">203</a> { +<a class="jxr_linenumber" name="L204" href="#L204">204</a> <strong class="jxr_keyword">public</strong> URLClassLoader run() +<a class="jxr_linenumber" name="L205" href="#L205">205</a> { +<a class="jxr_linenumber" name="L206" href="#L206">206</a> <strong class="jxr_keyword">return</strong> <strong class="jxr_keyword">new</strong> URLClassLoader( urls.toArray( <strong class="jxr_keyword">new</strong> URL[urls.size()] ), <strong class="jxr_keyword">null</strong> ); +<a class="jxr_linenumber" name="L207" href="#L207">207</a> } +<a class="jxr_linenumber" name="L208" href="#L208">208</a> } ); +<a class="jxr_linenumber" name="L209" href="#L209">209</a> +<a class="jxr_linenumber" name="L210" href="#L210">210</a> checker.setClassloader( projectClassLoader ); <a class="jxr_linenumber" name="L211" href="#L211">211</a> -<a class="jxr_linenumber" name="L212" href="#L212">212</a> checker.setClassloader( projectClassLoader ); +<a class="jxr_linenumber" name="L212" href="#L212">212</a> checker.setModuleClassLoader( Thread.currentThread().getContextClassLoader() ); <a class="jxr_linenumber" name="L213" href="#L213">213</a> -<a class="jxr_linenumber" name="L214" href="#L214">214</a> checker.setModuleClassLoader( Thread.currentThread().getContextClassLoader() ); -<a class="jxr_linenumber" name="L215" href="#L215">215</a> -<a class="jxr_linenumber" name="L216" href="#L216">216</a> <strong class="jxr_keyword">if</strong> ( filterSet != <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L217" href="#L217">217</a> { -<a class="jxr_linenumber" name="L218" href="#L218">218</a> checker.addFilter( filterSet ); -<a class="jxr_linenumber" name="L219" href="#L219">219</a> } -<a class="jxr_linenumber" name="L220" href="#L220">220</a> Configuration configuration = getConfiguration( request ); -<a class="jxr_linenumber" name="L221" href="#L221">221</a> checker.configure( configuration ); +<a class="jxr_linenumber" name="L214" href="#L214">214</a> <strong class="jxr_keyword">if</strong> ( filterSet != <strong class="jxr_keyword">null</strong> ) +<a class="jxr_linenumber" name="L215" href="#L215">215</a> { +<a class="jxr_linenumber" name="L216" href="#L216">216</a> checker.addFilter( filterSet ); +<a class="jxr_linenumber" name="L217" href="#L217">217</a> } +<a class="jxr_linenumber" name="L218" href="#L218">218</a> Configuration configuration = getConfiguration( request ); +<a class="jxr_linenumber" name="L219" href="#L219">219</a> checker.configure( configuration ); +<a class="jxr_linenumber" name="L220" href="#L220">220</a> +<a class="jxr_linenumber" name="L221" href="#L221">221</a> AuditListener listener = request.getListener(); <a class="jxr_linenumber" name="L222" href="#L222">222</a> -<a class="jxr_linenumber" name="L223" href="#L223">223</a> AuditListener listener = request.getListener(); -<a class="jxr_linenumber" name="L224" href="#L224">224</a> -<a class="jxr_linenumber" name="L225" href="#L225">225</a> <strong class="jxr_keyword">if</strong> ( listener != <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L226" href="#L226">226</a> { -<a class="jxr_linenumber" name="L227" href="#L227">227</a> checker.addListener( listener ); -<a class="jxr_linenumber" name="L228" href="#L228">228</a> } -<a class="jxr_linenumber" name="L229" href="#L229">229</a> -<a class="jxr_linenumber" name="L230" href="#L230">230</a> <strong class="jxr_keyword">if</strong> ( request.isConsoleOutput() ) -<a class="jxr_linenumber" name="L231" href="#L231">231</a> { -<a class="jxr_linenumber" name="L232" href="#L232">232</a> checker.addListener( request.getConsoleListener() ); -<a class="jxr_linenumber" name="L233" href="#L233">233</a> } -<a class="jxr_linenumber" name="L234" href="#L234">234</a> -<a class="jxr_linenumber" name="L235" href="#L235">235</a> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleCheckerListener.html">CheckstyleCheckerListener</a> checkerListener = <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleCheckerListener.html">CheckstyleCheckerListener</a>( configuration ); -<a class="jxr_linenumber" name="L236" href="#L236">236</a> <strong class="jxr_keyword">if</strong> ( request.isAggregate() ) -<a class="jxr_linenumber" name="L237" href="#L237">237</a> { -<a class="jxr_linenumber" name="L238" href="#L238">238</a> <strong class="jxr_keyword">for</strong> ( MavenProject childProject : request.getReactorProjects() ) -<a class="jxr_linenumber" name="L239" href="#L239">239</a> { -<a class="jxr_linenumber" name="L240" href="#L240">240</a> sourceDirectories = sourceDirectoriesByProject.get( childProject ); -<a class="jxr_linenumber" name="L241" href="#L241">241</a> testSourceDirectories = testSourceDirectoriesByProject.get( childProject ); -<a class="jxr_linenumber" name="L242" href="#L242">242</a> addSourceDirectory( checkerListener, sourceDirectories, -<a class="jxr_linenumber" name="L243" href="#L243">243</a> testSourceDirectories, -<a class="jxr_linenumber" name="L244" href="#L244">244</a> childProject.getResources(), request ); -<a class="jxr_linenumber" name="L245" href="#L245">245</a> } -<a class="jxr_linenumber" name="L246" href="#L246">246</a> } -<a class="jxr_linenumber" name="L247" href="#L247">247</a> <strong class="jxr_keyword">else</strong> -<a class="jxr_linenumber" name="L248" href="#L248">248</a> { -<a class="jxr_linenumber" name="L249" href="#L249">249</a> addSourceDirectory( checkerListener, sourceDirectories, testSourceDirectories, request.getResources(), -<a class="jxr_linenumber" name="L250" href="#L250">250</a> request ); -<a class="jxr_linenumber" name="L251" href="#L251">251</a> } +<a class="jxr_linenumber" name="L223" href="#L223">223</a> <strong class="jxr_keyword">if</strong> ( listener != <strong class="jxr_keyword">null</strong> ) +<a class="jxr_linenumber" name="L224" href="#L224">224</a> { +<a class="jxr_linenumber" name="L225" href="#L225">225</a> checker.addListener( listener ); +<a class="jxr_linenumber" name="L226" href="#L226">226</a> } +<a class="jxr_linenumber" name="L227" href="#L227">227</a> +<a class="jxr_linenumber" name="L228" href="#L228">228</a> <strong class="jxr_keyword">if</strong> ( request.isConsoleOutput() ) +<a class="jxr_linenumber" name="L229" href="#L229">229</a> { +<a class="jxr_linenumber" name="L230" href="#L230">230</a> checker.addListener( request.getConsoleListener() ); +<a class="jxr_linenumber" name="L231" href="#L231">231</a> } +<a class="jxr_linenumber" name="L232" href="#L232">232</a> +<a class="jxr_linenumber" name="L233" href="#L233">233</a> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleCheckerListener.html">CheckstyleCheckerListener</a> checkerListener = <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleCheckerListener.html">CheckstyleCheckerListener</a>( configuration ); +<a class="jxr_linenumber" name="L234" href="#L234">234</a> <strong class="jxr_keyword">if</strong> ( request.isAggregate() ) +<a class="jxr_linenumber" name="L235" href="#L235">235</a> { +<a class="jxr_linenumber" name="L236" href="#L236">236</a> <strong class="jxr_keyword">for</strong> ( MavenProject childProject : request.getReactorProjects() ) +<a class="jxr_linenumber" name="L237" href="#L237">237</a> { +<a class="jxr_linenumber" name="L238" href="#L238">238</a> sourceDirectories = sourceDirectoriesByProject.get( childProject ); +<a class="jxr_linenumber" name="L239" href="#L239">239</a> testSourceDirectories = testSourceDirectoriesByProject.get( childProject ); +<a class="jxr_linenumber" name="L240" href="#L240">240</a> addSourceDirectory( checkerListener, sourceDirectories, +<a class="jxr_linenumber" name="L241" href="#L241">241</a> testSourceDirectories, +<a class="jxr_linenumber" name="L242" href="#L242">242</a> childProject.getResources(), request ); +<a class="jxr_linenumber" name="L243" href="#L243">243</a> } +<a class="jxr_linenumber" name="L244" href="#L244">244</a> } +<a class="jxr_linenumber" name="L245" href="#L245">245</a> <strong class="jxr_keyword">else</strong> +<a class="jxr_linenumber" name="L246" href="#L246">246</a> { +<a class="jxr_linenumber" name="L247" href="#L247">247</a> addSourceDirectory( checkerListener, sourceDirectories, testSourceDirectories, request.getResources(), +<a class="jxr_linenumber" name="L248" href="#L248">248</a> request ); +<a class="jxr_linenumber" name="L249" href="#L249">249</a> } +<a class="jxr_linenumber" name="L250" href="#L250">250</a> +<a class="jxr_linenumber" name="L251" href="#L251">251</a> checker.addListener( checkerListener ); <a class="jxr_linenumber" name="L252" href="#L252">252</a> -<a class="jxr_linenumber" name="L253" href="#L253">253</a> checker.addListener( checkerListener ); +<a class="jxr_linenumber" name="L253" href="#L253">253</a> <strong class="jxr_keyword">int</strong> nbErrors = checker.process( files ); <a class="jxr_linenumber" name="L254" href="#L254">254</a> -<a class="jxr_linenumber" name="L255" href="#L255">255</a> <strong class="jxr_keyword">int</strong> nbErrors = checker.process( files ); +<a class="jxr_linenumber" name="L255" href="#L255">255</a> checker.destroy(); <a class="jxr_linenumber" name="L256" href="#L256">256</a> -<a class="jxr_linenumber" name="L257" href="#L257">257</a> checker.destroy(); -<a class="jxr_linenumber" name="L258" href="#L258">258</a> -<a class="jxr_linenumber" name="L259" href="#L259">259</a> <strong class="jxr_keyword">if</strong> ( projectClassLoader instanceof Closeable ) -<a class="jxr_linenumber" name="L260" href="#L260">260</a> { -<a class="jxr_linenumber" name="L261" href="#L261">261</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L262" href="#L262">262</a> { -<a class="jxr_linenumber" name="L263" href="#L263">263</a> ( ( Closeable ) projectClassLoader ).close(); -<a class="jxr_linenumber" name="L264" href="#L264">264</a> } -<a class="jxr_linenumber" name="L265" href="#L265">265</a> <strong class="jxr_keyword">catch</strong> ( IOException ex ) -<a class="jxr_linenumber" name="L266" href="#L266">266</a> { -<a class="jxr_linenumber" name="L267" href="#L267">267</a> <em class="jxr_comment">// Nothing we can do - and not detrimental to the build (save running out of file handles).</em> -<a class="jxr_linenumber" name="L268" href="#L268">268</a> getLogger().info( <span class="jxr_string">"Failed to close custom Classloader - this indicated a bug in the code."</span>, ex ); -<a class="jxr_linenumber" name="L269" href="#L269">269</a> } -<a class="jxr_linenumber" name="L270" href="#L270">270</a> } -<a class="jxr_linenumber" name="L271" href="#L271">271</a> -<a class="jxr_linenumber" name="L272" href="#L272">272</a> <strong class="jxr_keyword">if</strong> ( request.getStringOutputStream() != <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L273" href="#L273">273</a> { -<a class="jxr_linenumber" name="L274" href="#L274">274</a> request.getLog().info( request.getStringOutputStream().toString() ); -<a class="jxr_linenumber" name="L275" href="#L275">275</a> } -<a class="jxr_linenumber" name="L276" href="#L276">276</a> -<a class="jxr_linenumber" name="L277" href="#L277">277</a> <strong class="jxr_keyword">if</strong> ( request.isFailsOnError() && nbErrors > 0 ) -<a class="jxr_linenumber" name="L278" href="#L278">278</a> { -<a class="jxr_linenumber" name="L279" href="#L279">279</a> <em class="jxr_comment">// TODO: should be a failure, not an error. Report is not meant to</em> -<a class="jxr_linenumber" name="L280" href="#L280">280</a> <em class="jxr_comment">// throw an exception here (so site would</em> -<a class="jxr_linenumber" name="L281" href="#L281">281</a> <em class="jxr_comment">// work regardless of config), but should record this information</em> -<a class="jxr_linenumber" name="L282" href="#L282">282</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a>( <span class="jxr_string">"There are "</span> + nbErrors + <span class="jxr_string">" checkstyle errors."</span> ); -<a class="jxr_linenumber" name="L283" href="#L283">283</a> } -<a class="jxr_linenumber" name="L284" href="#L284">284</a> <strong class="jxr_keyword">else</strong> <strong class="jxr_keyword">if</strong> ( nbErrors > 0 ) -<a class="jxr_linenumber" name="L285" href="#L285">285</a> { -<a class="jxr_linenumber" name="L286" href="#L286">286</a> request.getLog().info( <span class="jxr_string">"There are "</span> + nbErrors + <span class="jxr_string">" checkstyle errors."</span> ); -<a class="jxr_linenumber" name="L287" href="#L287">287</a> } -<a class="jxr_linenumber" name="L288" href="#L288">288</a> -<a class="jxr_linenumber" name="L289" href="#L289">289</a> <strong class="jxr_keyword">return</strong> checkerListener.getResults(); -<a class="jxr_linenumber" name="L290" href="#L290">290</a> } -<a class="jxr_linenumber" name="L291" href="#L291">291</a> -<a class="jxr_linenumber" name="L292" href="#L292">292</a> <strong class="jxr_keyword">protected</strong> <strong class="jxr_keyword">void</strong> addSourceDirectory( CheckstyleCheckerListener sinkListener, Collection<File> sourceDirectories, -<a class="jxr_linenumber" name="L293" href="#L293">293</a> Collection<File> testSourceDirectories, List<Resource> resources, -<a class="jxr_linenumber" name="L294" href="#L294">294</a> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorRequest.html">CheckstyleExecutorRequest</a> request ) -<a class="jxr_linenumber" name="L295" href="#L295">295</a> { -<a class="jxr_linenumber" name="L296" href="#L296">296</a> <strong class="jxr_keyword">if</strong> ( sourceDirectories != <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L297" href="#L297">297</a> { -<a class="jxr_linenumber" name="L298" href="#L298">298</a> <strong class="jxr_keyword">for</strong> ( File sourceDirectory : sourceDirectories ) -<a class="jxr_linenumber" name="L299" href="#L299">299</a> { -<a class="jxr_linenumber" name="L300" href="#L300">300</a> <strong class="jxr_keyword">if</strong> ( sourceDirectory.exists() ) -<a class="jxr_linenumber" name="L301" href="#L301">301</a> { -<a class="jxr_linenumber" name="L302" href="#L302">302</a> sinkListener.addSourceDirectory( sourceDirectory ); -<a class="jxr_linenumber" name="L303" href="#L303">303</a> } -<a class="jxr_linenumber" name="L304" href="#L304">304</a> } -<a class="jxr_linenumber" name="L305" href="#L305">305</a> } -<a class="jxr_linenumber" name="L306" href="#L306">306</a> -<a class="jxr_linenumber" name="L307" href="#L307">307</a> <strong class="jxr_keyword">if</strong> ( request.isIncludeTestSourceDirectory() && ( testSourceDirectories != <strong class="jxr_keyword">null</strong> ) ) -<a class="jxr_linenumber" name="L308" href="#L308">308</a> { -<a class="jxr_linenumber" name="L309" href="#L309">309</a> <strong class="jxr_keyword">for</strong> ( File testSourceDirectory : testSourceDirectories ) -<a class="jxr_linenumber" name="L310" href="#L310">310</a> { -<a class="jxr_linenumber" name="L311" href="#L311">311</a> <strong class="jxr_keyword">if</strong>( testSourceDirectory.isDirectory() ) -<a class="jxr_linenumber" name="L312" href="#L312">312</a> { -<a class="jxr_linenumber" name="L313" href="#L313">313</a> sinkListener.addSourceDirectory( testSourceDirectory ); -<a class="jxr_linenumber" name="L314" href="#L314">314</a> } -<a class="jxr_linenumber" name="L315" href="#L315">315</a> } -<a class="jxr_linenumber" name="L316" href="#L316">316</a> } -<a class="jxr_linenumber" name="L317" href="#L317">317</a> -<a class="jxr_linenumber" name="L318" href="#L318">318</a> <strong class="jxr_keyword">if</strong> ( resources != <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L319" href="#L319">319</a> { -<a class="jxr_linenumber" name="L320" href="#L320">320</a> <strong class="jxr_keyword">for</strong> ( Resource resource : resources ) -<a class="jxr_linenumber" name="L321" href="#L321">321</a> { -<a class="jxr_linenumber" name="L322" href="#L322">322</a> <strong class="jxr_keyword">if</strong> ( resource.getDirectory() != <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L323" href="#L323">323</a> { -<a class="jxr_linenumber" name="L324" href="#L324">324</a> File resourcesDirectory = <strong class="jxr_keyword">new</strong> File( resource.getDirectory() ); -<a class="jxr_linenumber" name="L325" href="#L325">325</a> <strong class="jxr_keyword">if</strong> ( resourcesDirectory.exists() && resourcesDirectory.isDirectory() ) -<a class="jxr_linenumber" name="L326" href="#L326">326</a> { -<a class="jxr_linenumber" name="L327" href="#L327">327</a> sinkListener.addSourceDirectory( resourcesDirectory ); -<a class="jxr_linenumber" name="L328" href="#L328">328</a> getLogger().debug( <span class="jxr_string">"Added '"</span> + resourcesDirectory.getAbsolutePath() -<a class="jxr_linenumber" name="L329" href="#L329">329</a> + <span class="jxr_string">"' as a source directory."</span> ); -<a class="jxr_linenumber" name="L330" href="#L330">330</a> } -<a class="jxr_linenumber" name="L331" href="#L331">331</a> } -<a class="jxr_linenumber" name="L332" href="#L332">332</a> } -<a class="jxr_linenumber" name="L333" href="#L333">333</a> } -<a class="jxr_linenumber" name="L334" href="#L334">334</a> } -<a class="jxr_linenumber" name="L335" href="#L335">335</a> -<a class="jxr_linenumber" name="L336" href="#L336">336</a> <strong class="jxr_keyword">public</strong> Configuration getConfiguration( CheckstyleExecutorRequest request ) -<a class="jxr_linenumber" name="L337" href="#L337">337</a> <strong class="jxr_keyword">throws</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a> -<a class="jxr_linenumber" name="L338" href="#L338">338</a> { -<a class="jxr_linenumber" name="L339" href="#L339">339</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L340" href="#L340">340</a> { -<a class="jxr_linenumber" name="L341" href="#L341">341</a> <em class="jxr_comment">// Checkstyle will always use the context classloader in order</em> -<a class="jxr_linenumber" name="L342" href="#L342">342</a> <em class="jxr_comment">// to load resources (dtds),</em> -<a class="jxr_linenumber" name="L343" href="#L343">343</a> <em class="jxr_comment">// so we have to fix it</em> -<a class="jxr_linenumber" name="L344" href="#L344">344</a> ClassLoader checkstyleClassLoader = PackageNamesLoader.<strong class="jxr_keyword">class</strong>.getClassLoader(); -<a class="jxr_linenumber" name="L345" href="#L345">345</a> Thread.currentThread().setContextClassLoader( checkstyleClassLoader ); -<a class="jxr_linenumber" name="L346" href="#L346">346</a> String configFile = getConfigFile( request ); -<a class="jxr_linenumber" name="L347" href="#L347">347</a> Properties overridingProperties = getOverridingProperties( request ); -<a class="jxr_linenumber" name="L348" href="#L348">348</a> Configuration config = ConfigurationLoader -<a class="jxr_linenumber" name="L349" href="#L349">349</a> .loadConfiguration( configFile, <strong class="jxr_keyword">new</strong> PropertiesExpander( overridingProperties ) ); -<a class="jxr_linenumber" name="L350" href="#L350">350</a> String effectiveEncoding = StringUtils.isNotEmpty( request.getEncoding() ) ? request.getEncoding() : System -<a class="jxr_linenumber" name="L351" href="#L351">351</a> .getProperty( <span class="jxr_string">"file.encoding"</span>, <span class="jxr_string">"UTF-8"</span> ); -<a class="jxr_linenumber" name="L352" href="#L352">352</a> -<a class="jxr_linenumber" name="L353" href="#L353">353</a> <strong class="jxr_keyword">if</strong> ( StringUtils.isEmpty( request.getEncoding() ) ) -<a class="jxr_linenumber" name="L354" href="#L354">354</a> { -<a class="jxr_linenumber" name="L355" href="#L355">355</a> request.getLog().warn( -<a class="jxr_linenumber" name="L356" href="#L356">356</a> <span class="jxr_string">"File encoding has not been set, using platform encoding "</span> + effectiveEncoding -<a class="jxr_linenumber" name="L357" href="#L357">357</a> + <span class="jxr_string">", i.e. build is platform dependent!"</span> ); -<a class="jxr_linenumber" name="L358" href="#L358">358</a> } -<a class="jxr_linenumber" name="L359" href="#L359">359</a> -<a class="jxr_linenumber" name="L360" href="#L360">360</a> <strong class="jxr_keyword">if</strong> ( <span class="jxr_string">"Checker"</span>.equals( config.getName() ) -<a class="jxr_linenumber" name="L361" href="#L361">361</a> || <span class="jxr_string">"com.puppycrawl.tools.checkstyle.Checker"</span>.equals( config.getName() ) ) +<a class="jxr_linenumber" name="L257" href="#L257">257</a> <strong class="jxr_keyword">if</strong> ( projectClassLoader instanceof Closeable ) +<a class="jxr_linenumber" name="L258" href="#L258">258</a> { +<a class="jxr_linenumber" name="L259" href="#L259">259</a> <strong class="jxr_keyword">try</strong> +<a class="jxr_linenumber" name="L260" href="#L260">260</a> { +<a class="jxr_linenumber" name="L261" href="#L261">261</a> ( ( Closeable ) projectClassLoader ).close(); +<a class="jxr_linenumber" name="L262" href="#L262">262</a> } +<a class="jxr_linenumber" name="L263" href="#L263">263</a> <strong class="jxr_keyword">catch</strong> ( IOException ex ) +<a class="jxr_linenumber" name="L264" href="#L264">264</a> { +<a class="jxr_linenumber" name="L265" href="#L265">265</a> <em class="jxr_comment">// Nothing we can do - and not detrimental to the build (save running out of file handles).</em> +<a class="jxr_linenumber" name="L266" href="#L266">266</a> getLogger().info( <span class="jxr_string">"Failed to close custom Classloader - this indicated a bug in the code."</span>, ex ); +<a class="jxr_linenumber" name="L267" href="#L267">267</a> } +<a class="jxr_linenumber" name="L268" href="#L268">268</a> } +<a class="jxr_linenumber" name="L269" href="#L269">269</a> +<a class="jxr_linenumber" name="L270" href="#L270">270</a> <strong class="jxr_keyword">if</strong> ( request.getStringOutputStream() != <strong class="jxr_keyword">null</strong> ) +<a class="jxr_linenumber" name="L271" href="#L271">271</a> { +<a class="jxr_linenumber" name="L272" href="#L272">272</a> String message = request.getStringOutputStream().toString().trim(); +<a class="jxr_linenumber" name="L273" href="#L273">273</a> +<a class="jxr_linenumber" name="L274" href="#L274">274</a> <strong class="jxr_keyword">if</strong> ( message.length() > 0 ) +<a class="jxr_linenumber" name="L275" href="#L275">275</a> { +<a class="jxr_linenumber" name="L276" href="#L276">276</a> getLogger().info( message ); +<a class="jxr_linenumber" name="L277" href="#L277">277</a> } +<a class="jxr_linenumber" name="L278" href="#L278">278</a> } +<a class="jxr_linenumber" name="L279" href="#L279">279</a> +<a class="jxr_linenumber" name="L280" href="#L280">280</a> <strong class="jxr_keyword">if</strong> ( nbErrors > 0 ) +<a class="jxr_linenumber" name="L281" href="#L281">281</a> { +<a class="jxr_linenumber" name="L282" href="#L282">282</a> String message = <span class="jxr_string">"There are "</span> + nbErrors + <span class="jxr_string">" checkstyle errors."</span>; +<a class="jxr_linenumber" name="L283" href="#L283">283</a> +<a class="jxr_linenumber" name="L284" href="#L284">284</a> <strong class="jxr_keyword">if</strong> ( request.isFailsOnError() ) +<a class="jxr_linenumber" name="L285" href="#L285">285</a> { +<a class="jxr_linenumber" name="L286" href="#L286">286</a> <em class="jxr_comment">// TODO: should be a failure, not an error. Report is not meant to</em> +<a class="jxr_linenumber" name="L287" href="#L287">287</a> <em class="jxr_comment">// throw an exception here (so site would</em> +<a class="jxr_linenumber" name="L288" href="#L288">288</a> <em class="jxr_comment">// work regardless of config), but should record this information</em> +<a class="jxr_linenumber" name="L289" href="#L289">289</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a>( message ); +<a class="jxr_linenumber" name="L290" href="#L290">290</a> } +<a class="jxr_linenumber" name="L291" href="#L291">291</a> <strong class="jxr_keyword">else</strong> +<a class="jxr_linenumber" name="L292" href="#L292">292</a> { +<a class="jxr_linenumber" name="L293" href="#L293">293</a> getLogger().info( message ); +<a class="jxr_linenumber" name="L294" href="#L294">294</a> } +<a class="jxr_linenumber" name="L295" href="#L295">295</a> } +<a class="jxr_linenumber" name="L296" href="#L296">296</a> +<a class="jxr_linenumber" name="L297" href="#L297">297</a> <strong class="jxr_keyword">return</strong> checkerListener.getResults(); +<a class="jxr_linenumber" name="L298" href="#L298">298</a> } +<a class="jxr_linenumber" name="L299" href="#L299">299</a> +<a class="jxr_linenumber" name="L300" href="#L300">300</a> <strong class="jxr_keyword">protected</strong> <strong class="jxr_keyword">void</strong> addSourceDirectory( CheckstyleCheckerListener sinkListener, Collection<File> sourceDirectories, +<a class="jxr_linenumber" name="L301" href="#L301">301</a> Collection<File> testSourceDirectories, List<Resource> resources, +<a class="jxr_linenumber" name="L302" href="#L302">302</a> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorRequest.html">CheckstyleExecutorRequest</a> request ) +<a class="jxr_linenumber" name="L303" href="#L303">303</a> { +<a class="jxr_linenumber" name="L304" href="#L304">304</a> <strong class="jxr_keyword">if</strong> ( sourceDirectories != <strong class="jxr_keyword">null</strong> ) +<a class="jxr_linenumber" name="L305" href="#L305">305</a> { +<a class="jxr_linenumber" name="L306" href="#L306">306</a> <strong class="jxr_keyword">for</strong> ( File sourceDirectory : sourceDirectories ) +<a class="jxr_linenumber" name="L307" href="#L307">307</a> { +<a class="jxr_linenumber" name="L308" href="#L308">308</a> <strong class="jxr_keyword">if</strong> ( sourceDirectory.exists() ) +<a class="jxr_linenumber" name="L309" href="#L309">309</a> { +<a class="jxr_linenumber" name="L310" href="#L310">310</a> sinkListener.addSourceDirectory( sourceDirectory ); +<a class="jxr_linenumber" name="L311" href="#L311">311</a> } +<a class="jxr_linenumber" name="L312" href="#L312">312</a> } +<a class="jxr_linenumber" name="L313" href="#L313">313</a> } +<a class="jxr_linenumber" name="L314" href="#L314">314</a> +<a class="jxr_linenumber" name="L315" href="#L315">315</a> <strong class="jxr_keyword">if</strong> ( request.isIncludeTestSourceDirectory() && ( testSourceDirectories != <strong class="jxr_keyword">null</strong> ) ) +<a class="jxr_linenumber" name="L316" href="#L316">316</a> { +<a class="jxr_linenumber" name="L317" href="#L317">317</a> <strong class="jxr_keyword">for</strong> ( File testSourceDirectory : testSourceDirectories ) +<a class="jxr_linenumber" name="L318" href="#L318">318</a> { +<a class="jxr_linenumber" name="L319" href="#L319">319</a> <strong class="jxr_keyword">if</strong> ( testSourceDirectory.isDirectory() ) +<a class="jxr_linenumber" name="L320" href="#L320">320</a> { +<a class="jxr_linenumber" name="L321" href="#L321">321</a> sinkListener.addSourceDirectory( testSourceDirectory ); +<a class="jxr_linenumber" name="L322" href="#L322">322</a> } +<a class="jxr_linenumber" name="L323" href="#L323">323</a> } +<a class="jxr_linenumber" name="L324" href="#L324">324</a> } +<a class="jxr_linenumber" name="L325" href="#L325">325</a> +<a class="jxr_linenumber" name="L326" href="#L326">326</a> <strong class="jxr_keyword">if</strong> ( resources != <strong class="jxr_keyword">null</strong> ) +<a class="jxr_linenumber" name="L327" href="#L327">327</a> { +<a class="jxr_linenumber" name="L328" href="#L328">328</a> <strong class="jxr_keyword">for</strong> ( Resource resource : resources ) +<a class="jxr_linenumber" name="L329" href="#L329">329</a> { +<a class="jxr_linenumber" name="L330" href="#L330">330</a> <strong class="jxr_keyword">if</strong> ( resource.getDirectory() != <strong class="jxr_keyword">null</strong> ) +<a class="jxr_linenumber" name="L331" href="#L331">331</a> { +<a class="jxr_linenumber" name="L332" href="#L332">332</a> File resourcesDirectory = <strong class="jxr_keyword">new</strong> File( resource.getDirectory() ); +<a class="jxr_linenumber" name="L333" href="#L333">333</a> <strong class="jxr_keyword">if</strong> ( resourcesDirectory.exists() && resourcesDirectory.isDirectory() ) +<a class="jxr_linenumber" name="L334" href="#L334">334</a> { +<a class="jxr_linenumber" name="L335" href="#L335">335</a> sinkListener.addSourceDirectory( resourcesDirectory ); +<a class="jxr_linenumber" name="L336" href="#L336">336</a> getLogger().debug( <span class="jxr_string">"Added '"</span> + resourcesDirectory.getAbsolutePath() +<a class="jxr_linenumber" name="L337" href="#L337">337</a> + <span class="jxr_string">"' as a source directory."</span> ); +<a class="jxr_linenumber" name="L338" href="#L338">338</a> } +<a class="jxr_linenumber" name="L339" href="#L339">339</a> } +<a class="jxr_linenumber" name="L340" href="#L340">340</a> } +<a class="jxr_linenumber" name="L341" href="#L341">341</a> } +<a class="jxr_linenumber" name="L342" href="#L342">342</a> } +<a class="jxr_linenumber" name="L343" href="#L343">343</a> +<a class="jxr_linenumber" name="L344" href="#L344">344</a> <strong class="jxr_keyword">public</strong> Configuration getConfiguration( CheckstyleExecutorRequest request ) +<a class="jxr_linenumber" name="L345" href="#L345">345</a> <strong class="jxr_keyword">throws</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a> +<a class="jxr_linenumber" name="L346" href="#L346">346</a> { +<a class="jxr_linenumber" name="L347" href="#L347">347</a> <strong class="jxr_keyword">try</strong> +<a class="jxr_linenumber" name="L348" href="#L348">348</a> { +<a class="jxr_linenumber" name="L349" href="#L349">349</a> <em class="jxr_comment">// Checkstyle will always use the context classloader in order</em> +<a class="jxr_linenumber" name="L350" href="#L350">350</a> <em class="jxr_comment">// to load resources (dtds),</em> +<a class="jxr_linenumber" name="L351" href="#L351">351</a> <em class="jxr_comment">// so we have to fix it</em> +<a class="jxr_linenumber" name="L352" href="#L352">352</a> ClassLoader checkstyleClassLoader = PackageNamesLoader.<strong class="jxr_keyword">class</strong>.getClassLoader(); +<a class="jxr_linenumber" name="L353" href="#L353">353</a> Thread.currentThread().setContextClassLoader( checkstyleClassLoader ); +<a class="jxr_linenumber" name="L354" href="#L354">354</a> String configFile = getConfigFile( request ); +<a class="jxr_linenumber" name="L355" href="#L355">355</a> Properties overridingProperties = getOverridingProperties( request ); +<a class="jxr_linenumber" name="L356" href="#L356">356</a> Configuration config = ConfigurationLoader +<a class="jxr_linenumber" name="L357" href="#L357">357</a> .loadConfiguration( configFile, <strong class="jxr_keyword">new</strong> PropertiesExpander( overridingProperties ) ); +<a class="jxr_linenumber" name="L358" href="#L358">358</a> String effectiveEncoding = StringUtils.isNotEmpty( request.getEncoding() ) ? request.getEncoding() : System +<a class="jxr_linenumber" name="L359" href="#L359">359</a> .getProperty( <span class="jxr_string">"file.encoding"</span>, <span class="jxr_string">"UTF-8"</span> ); +<a class="jxr_linenumber" name="L360" href="#L360">360</a> +<a class="jxr_linenumber" name="L361" href="#L361">361</a> <strong class="jxr_keyword">if</strong> ( StringUtils.isEmpty( request.getEncoding() ) ) <a class="jxr_linenumber" name="L362" href="#L362">362</a> { -<a class="jxr_linenumber" name="L363" href="#L363">363</a> <strong class="jxr_keyword">if</strong> ( config instanceof DefaultConfiguration ) -<a class="jxr_linenumber" name="L364" href="#L364">364</a> { -<a class="jxr_linenumber" name="L365" href="#L365">365</a> <em class="jxr_comment">// MCHECKSTYLE-173 Only add the "charset" attribute if it has not been set</em> -<a class="jxr_linenumber" name="L366" href="#L366">366</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L367" href="#L367">367</a> { -<a class="jxr_linenumber" name="L368" href="#L368">368</a> <strong class="jxr_keyword">if</strong> ( config.getAttribute( <span class="jxr_string">"charset"</span> ) == <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L369" href="#L369">369</a> { -<a class="jxr_linenumber" name="L370" href="#L370">370</a> ( (DefaultConfiguration) config ).addAttribute( <span class="jxr_string">"charset"</span>, effectiveEncoding ); -<a class="jxr_linenumber" name="L371" href="#L371">371</a> } -<a class="jxr_linenumber" name="L372" href="#L372">372</a> } -<a class="jxr_linenumber" name="L373" href="#L373">373</a> <strong class="jxr_keyword">catch</strong> ( CheckstyleException ex ) +<a class="jxr_linenumber" name="L363" href="#L363">363</a> getLogger().warn( <span class="jxr_string">"File encoding has not been set, using platform encoding "</span> + effectiveEncoding +<a class="jxr_linenumber" name="L364" href="#L364">364</a> + <span class="jxr_string">", i.e. build is platform dependent!"</span> ); +<a class="jxr_linenumber" name="L365" href="#L365">365</a> } +<a class="jxr_linenumber" name="L366" href="#L366">366</a> +<a class="jxr_linenumber" name="L367" href="#L367">367</a> <strong class="jxr_keyword">if</strong> ( <span class="jxr_string">"Checker"</span>.equals( config.getName() ) +<a class="jxr_linenumber" name="L368" href="#L368">368</a> || <span class="jxr_string">"com.puppycrawl.tools.checkstyle.Checker"</span>.equals( config.getName() ) ) +<a class="jxr_linenumber" name="L369" href="#L369">369</a> { +<a class="jxr_linenumber" name="L370" href="#L370">370</a> <strong class="jxr_keyword">if</strong> ( config instanceof DefaultConfiguration ) +<a class="jxr_linenumber" name="L371" href="#L371">371</a> { +<a class="jxr_linenumber" name="L372" href="#L372">372</a> <em class="jxr_comment">// MCHECKSTYLE-173 Only add the "charset" attribute if it has not been set</em> +<a class="jxr_linenumber" name="L373" href="#L373">373</a> <strong class="jxr_keyword">try</strong> <a class="jxr_linenumber" name="L374" href="#L374">374</a> { -<a class="jxr_linenumber" name="L375" href="#L375">375</a> <em class="jxr_comment">// Checkstyle 5.4+ throws an exception when trying to access an attribute that doesn't exist</em> -<a class="jxr_linenumber" name="L376" href="#L376">376</a> ( (DefaultConfiguration) config ).addAttribute( <span class="jxr_string">"charset"</span>, effectiveEncoding ); -<a class="jxr_linenumber" name="L377" href="#L377">377</a> } -<a class="jxr_linenumber" name="L378" href="#L378">378</a> } -<a class="jxr_linenumber" name="L379" href="#L379">379</a> <strong class="jxr_keyword">else</strong> -<a class="jxr_linenumber" name="L380" href="#L380">380</a> { -<a class="jxr_linenumber" name="L381" href="#L381">381</a> request.getLog().warn( <span class="jxr_string">"Failed to configure file encoding on module "</span> + config ); -<a class="jxr_linenumber" name="L382" href="#L382">382</a> } -<a class="jxr_linenumber" name="L383" href="#L383">383</a> } -<a class="jxr_linenumber" name="L384" href="#L384">384</a> Configuration[] modules = config.getChildren(); -<a class="jxr_linenumber" name="L385" href="#L385">385</a> <strong class="jxr_keyword">for</strong> ( Configuration module : modules ) -<a class="jxr_linenumber" name="L386" href="#L386">386</a> { -<a class="jxr_linenumber" name="L387" href="#L387">387</a> <strong class="jxr_keyword">if</strong> ( <span class="jxr_string">"TreeWalker"</span>.equals( module.getName() ) -<a class="jxr_linenumber" name="L388" href="#L388">388</a> || <span class="jxr_string">"com.puppycrawl.tools.checkstyle.TreeWalker"</span>.equals( module.getName() ) ) -<a class="jxr_linenumber" name="L389" href="#L389">389</a> { -<a class="jxr_linenumber" name="L390" href="#L390">390</a> <strong class="jxr_keyword">if</strong> ( module instanceof DefaultConfiguration ) -<a class="jxr_linenumber" name="L391" href="#L391">391</a> { -<a class="jxr_linenumber" name="L392" href="#L392">392</a> <em class="jxr_comment">// MCHECKSTYLE-132 DefaultConfiguration addAttribute has changed in checkstyle 5.3</em> -<a class="jxr_linenumber" name="L393" href="#L393">393</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L394" href="#L394">394</a> { -<a class="jxr_linenumber" name="L395" href="#L395">395</a> <strong class="jxr_keyword">if</strong> ( module.getAttribute( <span class="jxr_string">"cacheFile"</span> ) == <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L396" href="#L396">396</a> { -<a class="jxr_linenumber" name="L397" href="#L397">397</a> ( (DefaultConfiguration) module ).addAttribute( <span class="jxr_string">"cacheFile"</span>, request.getCacheFile() ); -<a class="jxr_linenumber" name="L398" href="#L398">398</a> } -<a class="jxr_linenumber" name="L399" href="#L399">399</a> } -<a class="jxr_linenumber" name="L400" href="#L400">400</a> <strong class="jxr_keyword">catch</strong> ( CheckstyleException ex ) +<a class="jxr_linenumber" name="L375" href="#L375">375</a> <strong class="jxr_keyword">if</strong> ( config.getAttribute( <span class="jxr_string">"charset"</span> ) == <strong class="jxr_keyword">null</strong> ) +<a class="jxr_linenumber" name="L376" href="#L376">376</a> { +<a class="jxr_linenumber" name="L377" href="#L377">377</a> ( (DefaultConfiguration) config ).addAttribute( <span class="jxr_string">"charset"</span>, effectiveEncoding ); +<a class="jxr_linenumber" name="L378" href="#L378">378</a> } +<a class="jxr_linenumber" name="L379" href="#L379">379</a> } +<a class="jxr_linenumber" name="L380" href="#L380">380</a> <strong class="jxr_keyword">catch</strong> ( CheckstyleException ex ) +<a class="jxr_linenumber" name="L381" href="#L381">381</a> { +<a class="jxr_linenumber" name="L382" href="#L382">382</a> <em class="jxr_comment">// Checkstyle 5.4+ throws an exception when trying to access an attribute that doesn't exist</em> +<a class="jxr_linenumber" name="L383" href="#L383">383</a> ( (DefaultConfiguration) config ).addAttribute( <span class="jxr_string">"charset"</span>, effectiveEncoding ); +<a class="jxr_linenumber" name="L384" href="#L384">384</a> } +<a class="jxr_linenumber" name="L385" href="#L385">385</a> } +<a class="jxr_linenumber" name="L386" href="#L386">386</a> <strong class="jxr_keyword">else</strong> +<a class="jxr_linenumber" name="L387" href="#L387">387</a> { +<a class="jxr_linenumber" name="L388" href="#L388">388</a> getLogger().warn( <span class="jxr_string">"Failed to configure file encoding on module "</span> + config ); +<a class="jxr_linenumber" name="L389" href="#L389">389</a> } +<a class="jxr_linenumber" name="L390" href="#L390">390</a> } +<a class="jxr_linenumber" name="L391" href="#L391">391</a> Configuration[] modules = config.getChildren(); +<a class="jxr_linenumber" name="L392" href="#L392">392</a> <strong class="jxr_keyword">for</strong> ( Configuration module : modules ) +<a class="jxr_linenumber" name="L393" href="#L393">393</a> { +<a class="jxr_linenumber" name="L394" href="#L394">394</a> <strong class="jxr_keyword">if</strong> ( <span class="jxr_string">"TreeWalker"</span>.equals( module.getName() ) +<a class="jxr_linenumber" name="L395" href="#L395">395</a> || <span class="jxr_string">"com.puppycrawl.tools.checkstyle.TreeWalker"</span>.equals( module.getName() ) ) +<a class="jxr_linenumber" name="L396" href="#L396">396</a> { +<a class="jxr_linenumber" name="L397" href="#L397">397</a> <strong class="jxr_keyword">if</strong> ( module instanceof DefaultConfiguration ) +<a class="jxr_linenumber" name="L398" href="#L398">398</a> { +<a class="jxr_linenumber" name="L399" href="#L399">399</a> <em class="jxr_comment">// MCHECKSTYLE-132 DefaultConfiguration addAttribute has changed in checkstyle 5.3</em> +<a class="jxr_linenumber" name="L400" href="#L400">400</a> <strong class="jxr_keyword">try</strong> <a class="jxr_linenumber" name="L401" href="#L401">401</a> { -<a class="jxr_linenumber" name="L402" href="#L402">402</a> <em class="jxr_comment">// MCHECKSTYLE-159 - checkstyle 5.4 throws an exception instead of return null if</em> -<a class="jxr_linenumber" name="L403" href="#L403">403</a> <em class="jxr_comment">// "cacheFile"</em> -<a class="jxr_linenumber" name="L404" href="#L404">404</a> <em class="jxr_comment">// doesn't exist</em> -<a class="jxr_linenumber" name="L405" href="#L405">405</a> ( (DefaultConfiguration) module ).addAttribute( <span class="jxr_string">"cacheFile"</span>, request.getCacheFile() ); +<a class="jxr_linenumber" name="L402" href="#L402">402</a> <strong class="jxr_keyword">if</strong> ( module.getAttribute( <span class="jxr_string">"cacheFile"</span> ) == <strong class="jxr_keyword">null</strong> ) +<a class="jxr_linenumber" name="L403" href="#L403">403</a> { +<a class="jxr_linenumber" name="L404" href="#L404">404</a> ( (DefaultConfiguration) module ).addAttribute( <span class="jxr_string">"cacheFile"</span>, request.getCacheFile() ); +<a class="jxr_linenumber" name="L405" href="#L405">405</a> } <a class="jxr_linenumber" name="L406" href="#L406">406</a> } -<a class="jxr_linenumber" name="L407" href="#L407">407</a> } -<a class="jxr_linenumber" name="L408" href="#L408">408</a> <strong class="jxr_keyword">else</strong> -<a class="jxr_linenumber" name="L409" href="#L409">409</a> { -<a class="jxr_linenumber" name="L410" href="#L410">410</a> request.getLog().warn( <span class="jxr_string">"Failed to configure cache file on module "</span> + module ); -<a class="jxr_linenumber" name="L411" href="#L411">411</a> } -<a class="jxr_linenumber" name="L412" href="#L412">412</a> } -<a class="jxr_linenumber" name="L413" href="#L413">413</a> } -<a class="jxr_linenumber" name="L414" href="#L414">414</a> <strong class="jxr_keyword">return</strong> config; -<a class="jxr_linenumber" name="L415" href="#L415">415</a> } -<a class="jxr_linenumber" name="L416" href="#L416">416</a> <strong class="jxr_keyword">catch</strong> ( CheckstyleException e ) -<a class="jxr_linenumber" name="L417" href="#L417">417</a> { -<a class="jxr_linenumber" name="L418" href="#L418">418</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a>( <span class="jxr_string">"Failed during checkstyle configuration"</span>, e ); -<a class="jxr_linenumber" name="L419" href="#L419">419</a> } -<a class="jxr_linenumber" name="L420" href="#L420">420</a> } -<a class="jxr_linenumber" name="L421" href="#L421">421</a> -<a class="jxr_linenumber" name="L422" href="#L422">422</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">void</strong> prepareCheckstylePaths( CheckstyleExecutorRequest request, MavenProject project, -<a class="jxr_linenumber" name="L423" href="#L423">423</a> List<String> classPathStrings, List<String> outputDirectories, -<a class="jxr_linenumber" name="L424" href="#L424">424</a> Collection<File> sourceDirectories, Collection<File> testSourceDirectories ) -<a class="jxr_linenumber" name="L425" href="#L425">425</a> <strong class="jxr_keyword">throws</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a> -<a class="jxr_linenumber" name="L426" href="#L426">426</a> { -<a class="jxr_linenumber" name="L427" href="#L427">427</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L428" href="#L428">428</a> { -<a class="jxr_linenumber" name="L429" href="#L429">429</a> outputDirectories.add( project.getBuild().getOutputDirectory() ); -<a class="jxr_linenumber" name="L430" href="#L430">430</a> -<a class="jxr_linenumber" name="L431" href="#L431">431</a> <strong class="jxr_keyword">if</strong> ( request.isIncludeTestSourceDirectory() && ( testSourceDirectories != <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L432" href="#L432">432</a> && anyDirectoryExists( testSourceDirectories ) ) -<a class="jxr_linenumber" name="L433" href="#L433">433</a> { -<a class="jxr_linenumber" name="L434" href="#L434">434</a> classPathStrings.addAll( project.getTestClasspathElements() ); -<a class="jxr_linenumber" name="L435" href="#L435">435</a> outputDirectories.add( project.getBuild().getTestOutputDirectory() ); -<a class="jxr_linenumber" name="L436" href="#L436">436</a> } -<a class="jxr_linenumber" name="L437" href="#L437">437</a> <strong class="jxr_keyword">else</strong> -<a class="jxr_linenumber" name="L438" href="#L438">438</a> { -<a class="jxr_linenumber" name="L439" href="#L439">439</a> classPathStrings.addAll( project.getCompileClasspathElements() ); -<a class="jxr_linenumber" name="L440" href="#L440">440</a> } -<a class="jxr_linenumber" name="L441" href="#L441">441</a> } -<a class="jxr_linenumber" name="L442" href="#L442">442</a> <strong class="jxr_keyword">catch</strong> ( DependencyResolutionRequiredException e ) -<a class="jxr_linenumber" name="L443" href="#L443">443</a> { -<a class="jxr_linenumber" name="L444" href="#L444">444</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a>( e.getMessage(), e ); -<a class="jxr_linenumber" name="L445" href="#L445">445</a> } -<a class="jxr_linenumber" name="L446" href="#L446">446</a> } -<a class="jxr_linenumber" name="L447" href="#L447">447</a> -<a class="jxr_linenumber" name="L448" href="#L448">448</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">boolean</strong> anyDirectoryExists( Collection<File> files ) -<a class="jxr_linenumber" name="L449" href="#L449">449</a> { -<a class="jxr_linenumber" name="L450" href="#L450">450</a> <strong class="jxr_keyword">for</strong> ( File file : files ) -<a class="jxr_linenumber" name="L451" href="#L451">451</a> { -<a class="jxr_linenumber" name="L452" href="#L452">452</a> <strong class="jxr_keyword">if</strong> ( file.isDirectory() ) -<a class="jxr_linenumber" name="L453" href="#L453">453</a> { -<a class="jxr_linenumber" name="L454" href="#L454">454</a> <strong class="jxr_keyword">return</strong> <strong class="jxr_keyword">true</strong>; -<a class="jxr_linenumber" name="L455" href="#L455">455</a> } -<a class="jxr_linenumber" name="L456" href="#L456">456</a> } -<a class="jxr_linenumber" name="L457" href="#L457">457</a> <strong class="jxr_keyword">return</strong> false; -<a class="jxr_linenumber" name="L458" href="#L458">458</a> } -<a class="jxr_linenumber" name="L459" href="#L459">459</a> -<a class="jxr_linenumber" name="L460" href="#L460">460</a> <strong class="jxr_keyword">private</strong> Properties getOverridingProperties( CheckstyleExecutorRequest request ) -<a class="jxr_linenumber" name="L461" href="#L461">461</a> <strong class="jxr_keyword">throws</strong> <a href="../../../../../../org/apache/maven/plugin/checkstyle/exec/CheckstyleExecutorException.html">CheckstyleExecutorException</a> -<a class="jxr_linenumber" name="L462" href="#L462">462</a> { -<a class="jxr_linenumber" name="L463" href="#L463">463</a> Properties p = <strong class="jxr_keyword">new</strong> Properties(); -<a class="jxr_linenumber" name="L464" href="#L464">464</a> -<a class="jxr_linenumber" name="L465" href="#L465">465</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L466" href="#L466">466</a> { -<a class="jxr_linenumber" name="L467" href="#L467">467</a> <strong class="jxr_keyword">if</strong> ( request.getPropertiesLocation() != <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L468" href="#L468">468</a> { -<a class="jxr_linenumber" name="L469" href="#L469">469</a> <strong class="jxr_keyword">if</strong> ( getLogger().isDebugEnabled() ) -<a class="jxr_linenumber" name="L470" href="#L470">470</a> { -<a class="jxr_linenumber" name="L471" href="#L471">471</a> getLogger().debug( <span class="jxr_string">"request.getPropertiesLocation() "</span> + request.getPropertiesLocation() ); -<a class="jxr_linenumber" name="L472" href="#L472">472</a> } -<a class="jxr_linenumber" name="L473" href="#L473">473</a> -<a class="jxr_linenumber" name="L474" href="#L474">474</a> File propertiesFile = locator.getResourceAsFile( request.getPropertiesLocation(), -<a class="jxr_linenumber" name="L475" href="#L475">475</a> <span class="jxr_string">"checkstyle-checker.properties"</span> ); -<a class="jxr_linenumber" name="L476" href="#L476">476</a> -<a class="jxr_linenumber" name="L477" href="#L477">477</a> FileInputStream properties = <strong class="jxr_keyword">new</strong> FileInputStream( propertiesFile ); -<a class="jxr_linenumber" name="L478" href="#L478">478</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L479" href="#L479">479</a> { -<a class="jxr_linenumber" name="L480" href="#L480">480</a> <strong class="jxr_keyword">if</strong> ( propertiesFile != <strong class="jxr_keyword">null</strong> ) -<a class="jxr_linenumber" name="L481" href="#L481">481</a> { -<a class="jxr_linenumber" name="L482" href="#L482">482</a> p.load( properties ); -<a class="jxr_linenumber" name="L483" href="#L483">483</a> } -<a class="jxr_linenumber" name="L484" href="#L484">484</a> } -<a class="jxr_linenumber" name="L485" href="#L485">485</a> <strong class="jxr_keyword">finally</strong> +<a class="jxr_linenumber" name="L407" href="#L407">407</a> <strong class="jxr_keyword">catch</strong> ( CheckstyleException ex ) +<a class="jxr_linenumber" name="L408" href="#L408">408</a> { +<a class="jxr_linenumber" name="L409" href="#L409">409</a> <em class="jxr_comment">// MCHECKSTYLE-159 - checkstyle 5.4 throws an exception instead of return null if</em> +<a class="jxr_linenumber" name="L410" href="#L410">410</a> <em class="jxr_comment">// "cacheFile"</em> +<a class="jxr_linenumber" name="L411" href="#L411">411</a> <em class="jxr_comment">// doesn't exist</em> +<a class="jxr_linenumber" name="L412" href="#L412">412</a> ( (DefaultConfiguration) module ).addAttribute( <span class="jxr_string">"cacheFile"</span>, request.getCacheFile() ); +<a class="jxr_linenumber" name="L413" href="#L413">413</a> } +<a class="jxr_linenumber" name="L414" href="#L414">414</a> } +<a class="jxr_linenumber" name="L415" href="#L415">415</a> <strong class="jxr_keyword">else</strong> +<a class="jxr_linenumber" name="L416" href="#L416">416</a> { +<a class="jxr_linenumber" name="L417" href="#L417">417</a> getLogger().warn( <span class="jxr_string">"Failed to configure cache file on module "</span> + module ); +<a class="jxr_linenumber" name="L418" href="#L418">418</a> } +<a class="jxr_linenumber" name="L419" href="#L419">419</a> } +<a class="jxr_linenumber" name="L420" href="#L420">420</a> }
[... 814 lines stripped ...]