Revision: 3199
http://skim-app.svn.sourceforge.net/skim-app/?rev=3199&view=rev
Author: amaxwell
Date: 2007-11-12 13:03:01 -0800 (Mon, 12 Nov 2007)
Log Message:
-----------
Fix bug #1829122. It's never correct to assume that an NSError** was
initialized to nil.
Modified Paths:
--------------
trunk/SKDocument.m
Modified: trunk/SKDocument.m
===================================================================
--- trunk/SKDocument.m 2007-11-12 18:56:21 UTC (rev 3198)
+++ trunk/SKDocument.m 2007-11-12 21:03:01 UTC (rev 3199)
@@ -376,7 +376,7 @@
exportUsingPanel = NO;
- if (success == NO && outError != NULL && *outError == nil)
+ if (success == NO && outError != NULL)
*outError = [NSError errorWithDomain:SKDocumentErrorDomain code:0
userInfo:[NSDictionary dictionaryWithObjectsAndKeys:NSLocalizedString(@"Unable
to write file", @"Error description"), NSLocalizedDescriptionKey, nil]];
return success;
@@ -458,7 +458,7 @@
*outError = [NSError errorWithDomain:SKDocumentErrorDomain code:1
userInfo:[NSDictionary dictionaryWithObjectsAndKeys:NSLocalizedString(@"Unable
to write notes as FDF", @"Error description"), NSLocalizedDescriptionKey, nil]];
}
- if (didWrite == NO && outError != NULL && *outError == nil)
+ if (didWrite == NO && outError != NULL)
*outError = [NSError errorWithDomain:SKDocumentErrorDomain code:0
userInfo:[NSDictionary dictionaryWithObjectsAndKeys:NSLocalizedString(@"Unable
to write file", @"Error description"), NSLocalizedDescriptionKey, nil]];
return didWrite;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
