Revision: 13343
          http://sourceforge.net/p/skim-app/code/13343
Author:   hofman
Date:     2023-03-05 22:20:53 +0000 (Sun, 05 Mar 2023)
Log Message:
-----------
make sure dashPattern is reset from properties when it was nil

Modified Paths:
--------------
    trunk/SkimNotes/PDFAnnotation_SKNExtensions.m

Modified: trunk/SkimNotes/PDFAnnotation_SKNExtensions.m
===================================================================
--- trunk/SkimNotes/PDFAnnotation_SKNExtensions.m       2023-03-04 18:08:32 UTC 
(rev 13342)
+++ trunk/SkimNotes/PDFAnnotation_SKNExtensions.m       2023-03-05 22:20:53 UTC 
(rev 13343)
@@ -370,6 +370,8 @@
         if ([userName isKindOfClass:stringClass] && [self 
respondsToSelector:@selector(setUserName:)])
             [self setUserName:userName];
         if (lineWidth || borderStyle || dashPattern) {
+            if ([borderStyle respondsToSelector:@selector(integerValue)] == NO)
+                borderStyle = nil;
             if ([self border] == nil)
                 [self setBorder:[[[PDFBorder alloc] init] autorelease]];
             if ([lineWidth respondsToSelector:@selector(doubleValue)])
@@ -376,7 +378,11 @@
                 [[self border] setLineWidth:[lineWidth doubleValue]];
             if ([dashPattern isKindOfClass:arrayClass])
                 [[self border] setDashPattern:dashPattern];
-            if ([borderStyle respondsToSelector:@selector(integerValue)])
+            else if ([borderStyle integerValue] == kPDFBorderStyleDashed)
+                [[self border] setDashPattern:[NSArray array]];
+            else
+                [[self border] setDashPattern:nil];
+            if (borderStyle)
                 [[self border] setStyle:[borderStyle integerValue]];
         } else if ([self border]) {
             [self setBorder:nil];

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to