Revision: 13605
          http://sourceforge.net/p/skim-app/code/13605
Author:   hofman
Date:     2023-08-24 14:40:16 +0000 (Thu, 24 Aug 2023)
Log Message:
-----------
allow clicking a link in note tool mode, but only when the mouse is not dragged

Modified Paths:
--------------
    trunk/SKPDFView.m

Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m   2023-08-23 17:47:45 UTC (rev 13604)
+++ trunk/SKPDFView.m   2023-08-24 14:40:16 UTC (rev 13605)
@@ -2049,7 +2049,9 @@
             [self doDragMouseWithEvent:theEvent];
         }
     } else if (toolMode == SKNoteToolMode && pdfvFlags.hideNotes == NO && 
[[self document] allowsNotes] && IS_MARKUP(annotationMode) == NO) {
-        if (annotationMode == SKInkNote) {
+        if ((area & kPDFLinkArea) != 0 && [NSApp willDragMouse] == NO) {
+            [super mouseDown:theEvent];
+        } else if (annotationMode == SKInkNote) {
             [self doDrawFreehandNoteWithEvent:theEvent];
         } else {
             [self setCurrentAnnotation:nil];
@@ -5381,8 +5383,6 @@
             if ((area & SKReadingBarArea) == 0)
                 area |= SKDragArea;
         } else if (toolMode == SKTextToolMode || toolMode == SKNoteToolMode) {
-            if (toolMode == SKNoteToolMode)
-                area &= ~kPDFLinkArea;
             if (editor && [[currentAnnotation page] isEqual:page] && 
NSPointInRect(p, [currentAnnotation bounds])) {
                 area = kPDFTextFieldArea;
             } else if ((area & SKReadingBarArea) == 0) {

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to