Revision: 14734
http://sourceforge.net/p/skim-app/code/14734
Author: hofman
Date: 2024-11-21 10:05:34 +0000 (Thu, 21 Nov 2024)
Log Message:
-----------
Do use separate methods for services to open a file as notes or not, for
backwards compatibility because the services are registered by how they are
called
Modified Paths:
--------------
trunk/Info.plist
trunk/SKDocumentController.m
Modified: trunk/Info.plist
===================================================================
--- trunk/Info.plist 2024-11-20 23:35:57 UTC (rev 14733)
+++ trunk/Info.plist 2024-11-21 10:05:34 UTC (rev 14734)
@@ -433,7 +433,7 @@
<string>Show Skim Notes</string>
</dict>
<key>NSMessage</key>
- <string>openDocumentFromURLOnPboard</string>
+ <string>openNotesDocumentFromURLOnPboard</string>
<key>NSPortName</key>
<string>Skim</string>
<key>NSRequiredContext</key>
@@ -457,8 +457,6 @@
<string>public.file-url</string>
<string>public.plain-text</string>
</array>
- <key>NSUserData</key>
- <string>1</string>
</dict>
<dict>
<key>NSMenuItem</key>
Modified: trunk/SKDocumentController.m
===================================================================
--- trunk/SKDocumentController.m 2024-11-20 23:35:57 UTC (rev 14733)
+++ trunk/SKDocumentController.m 2024-11-21 10:05:34 UTC (rev 14734)
@@ -679,14 +679,17 @@
#pragma mark Services Support
- (void)openDocumentFromURLOnPboard:(NSPasteboard *)pboard userData:(NSString
*)userData error:(out NSString * __autoreleasing *)errorString {
- [self openDocumentWithURLFromPasteboard:pboard showNotes:[userData
boolValue] completionHandler:^(NSDocument *document, BOOL
documentWasAlreadyOpen, NSError *error){}];
+ [self openDocumentWithURLFromPasteboard:pboard showNotes:NO
completionHandler:^(NSDocument *document, BOOL documentWasAlreadyOpen, NSError
*error){}];
}
- (void)openDocumentFromDataOnPboard:(NSPasteboard *)pboard userData:(NSString
*)userData error:(out NSString * __autoreleasing *)errorString {
[self openDocumentWithImageFromPasteboard:pboard
completionHandler:^(NSDocument *document, BOOL documentWasAlreadyOpen, NSError
*error){}];
-
}
+- (void)openNotesDocumentFromURLOnPboard:(NSPasteboard *)pboard
userData:(NSString *)userData error:(out NSString * __autoreleasing
*)errorString {
+ [self openDocumentWithURLFromPasteboard:pboard showNotes:YES
completionHandler:^(NSDocument *document, BOOL documentWasAlreadyOpen, NSError
*error){}];
+}
+
- (void)printDocumentFromURLOnPboard:(NSPasteboard *)pboard userData:(NSString
*)userData error:(out NSString * __autoreleasing *)errorString {
NSURL *theURL = [[NSURL readURLsFromPasteboard:pboard] firstObject];
if ([theURL isFileURL] && [[NSApp delegate]
respondsToSelector:@selector(application:printFiles:withSettings:showPrintPanels:)])
{
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
