Revision: 14753
http://sourceforge.net/p/skim-app/code/14753
Author: hofman
Date: 2024-11-27 10:37:14 +0000 (Wed, 27 Nov 2024)
Log Message:
-----------
use pdfView as parameter name of delegate method
Modified Paths:
--------------
trunk/SKMainWindowController_UI.m
trunk/SKPDFView.h
trunk/SKSnapshotPDFView.h
trunk/SKSnapshotWindowController.m
Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m 2024-11-27 10:34:31 UTC (rev 14752)
+++ trunk/SKMainWindowController_UI.m 2024-11-27 10:37:14 UTC (rev 14753)
@@ -1476,7 +1476,7 @@
return url;
}
-- (void)PDFViewOpenPDF:(PDFView *)sender
forRemoteGoToAction:(PDFActionRemoteGoTo *)action {
+- (void)PDFViewOpenPDF:(PDFView *)aPDFView
forRemoteGoToAction:(PDFActionRemoteGoTo *)action {
NSURL *fileURL = [self redirectRelativeLinkURL:[action URL]];
SKDocumentController *sdc = [NSDocumentController
sharedDocumentController];
Class docClass = [sdc documentClassForContentsOfURL:fileURL];
@@ -1499,7 +1499,7 @@
}
}
-- (void)PDFViewWillClickOnLink:(PDFView *)sender withURL:(NSURL *)url {
+- (void)PDFViewWillClickOnLink:(PDFView *)aPDFView withURL:(NSURL *)url {
SKDocumentController *sdc = [NSDocumentController
sharedDocumentController];
url = [self redirectRelativeLinkURL:url];
if ([url isFileURL] && [sdc documentClassForContentsOfURL:url]) {
@@ -1519,7 +1519,7 @@
}
}
-- (void)PDFViewPerformFind:(PDFView *)sender {
+- (void)PDFViewPerformFind:(PDFView *)aPDFView {
BOOL wasVisible = [[findController view] window] != nil;
[self showFindBar];
if (wasVisible == NO)
@@ -1526,7 +1526,7 @@
NSAccessibilityPostNotificationWithUserInfo(NSAccessibilityUnignoredAncestor([pdfView
documentView]), NSAccessibilityLayoutChangedNotification, [NSDictionary
dictionaryWithObjectsAndKeys:NSAccessibilityUnignoredChildrenForOnlyChild([findController
view]), NSAccessibilityUIElementsKey, nil]);
}
-- (void)PDFViewPerformHideFind:(PDFView *)sender {
+- (void)PDFViewPerformHideFind:(PDFView *)aPDFView {
if ([[findController view] window]) {
[findController remove:nil];
NSAccessibilityPostNotificationWithUserInfo(NSAccessibilityUnignoredAncestor([pdfView
documentView]), NSAccessibilityLayoutChangedNotification, nil);
@@ -1533,39 +1533,39 @@
}
}
-- (BOOL)PDFViewIsFindVisible:(PDFView *)sender {
+- (BOOL)PDFViewIsFindVisible:(PDFView *)aPDFView {
return [[findController view] window] != nil;
}
-- (void)PDFViewPerformGoToPage:(PDFView *)sender {
- [self doGoToPage:sender];
+- (void)PDFViewPerformGoToPage:(PDFView *)aPDFView {
+ [self doGoToPage:aPDFView];
}
-- (void)PDFViewPerformPrint:(PDFView *)sender {
- [[self document] printDocument:sender];
+- (void)PDFViewPerformPrint:(PDFView *)aPDFView {
+ [[self document] printDocument:aPDFView];
}
-- (void)PDFViewDidBeginEditing:(PDFView *)sender {
+- (void)PDFViewDidBeginEditing:(PDFView *)aPDFView {
if (mwcFlags.isEditingPDF == NO && mwcFlags.isEditingTable == NO)
[[self document] objectDidBeginEditing:(id)self];
mwcFlags.isEditingPDF = YES;
}
-- (void)PDFViewDidEndEditing:(PDFView *)sender {
+- (void)PDFViewDidEndEditing:(PDFView *)aPDFView {
if (mwcFlags.isEditingPDF && mwcFlags.isEditingTable == NO)
[[self document] objectDidEndEditing:(id)self];
mwcFlags.isEditingPDF = NO;
}
-- (void)PDFView:(PDFView *)sender editAnnotation:(PDFAnnotation *)annotation {
+- (void)PDFView:(PDFView *)aPDFView editAnnotation:(PDFAnnotation *)annotation
{
[self showNote:annotation];
}
-- (void)PDFView:(PDFView *)sender showSnapshotAtPageNumber:(NSInteger)pageNum
forRect:(NSRect)rect scaleFactor:(CGFloat)scaleFactor autoFits:(BOOL)autoFits {
+- (void)PDFView:(PDFView *)aPDFView
showSnapshotAtPageNumber:(NSInteger)pageNum forRect:(NSRect)rect
scaleFactor:(CGFloat)scaleFactor autoFits:(BOOL)autoFits {
[self showSnapshotAtPageNumber:pageNum forRect:rect
scaleFactor:scaleFactor autoFits:autoFits];
}
-- (void)PDFView:(PDFView *)sender didRotatePageAtIndex:(NSUInteger)idx
by:(NSInteger)rotation {
+- (void)PDFView:(PDFView *)aPDFView didRotatePageAtIndex:(NSUInteger)idx
by:(NSInteger)rotation {
NSUndoManager *undoManager = [[self document] undoManager];
[[undoManager prepareWithInvocationTarget:self] rotatePageAtIndex:idx
by:-rotation];
[undoManager setActionName:NSLocalizedString(@"Rotate Page", @"Undo action
name")];
@@ -1576,7 +1576,7 @@
object:[pdfView
document] userInfo:@{SKPDFPageActionKey:SKPDFPageActionRotate,
SKPDFPagePageKey:page}];
}
-- (NSUndoManager *)undoManagerForPDFView:(PDFView *)sender {
+- (NSUndoManager *)undoManagerForPDFView:(PDFView *)aPDFView {
return [[self document] undoManager];
}
Modified: trunk/SKPDFView.h
===================================================================
--- trunk/SKPDFView.h 2024-11-27 10:34:31 UTC (rev 14752)
+++ trunk/SKPDFView.h 2024-11-27 10:37:14 UTC (rev 14753)
@@ -119,14 +119,14 @@
@protocol SKPDFViewDelegate <PDFViewDelegate>
@optional
-- (void)PDFViewDidBeginEditing:(PDFView *)sender;
-- (void)PDFViewDidEndEditing:(PDFView *)sender;
-- (void)PDFView:(PDFView *)sender editAnnotation:(PDFAnnotation *)annotation;
-- (void)PDFView:(PDFView *)sender showSnapshotAtPageNumber:(NSInteger)pageNum
forRect:(NSRect)rect scaleFactor:(CGFloat)scaleFactor autoFits:(BOOL)autoFits;
-- (void)PDFViewPerformHideFind:(PDFView *)sender;
-- (BOOL)PDFViewIsFindVisible:(PDFView *)sender;
-- (void)PDFView:(PDFView *)sender didRotatePageAtIndex:(NSUInteger)idx
by:(NSInteger)rotation;
-- (nullable NSUndoManager *)undoManagerForPDFView:(PDFView *)sender;
+- (void)PDFViewDidBeginEditing:(PDFView *)pdfView;
+- (void)PDFViewDidEndEditing:(PDFView *)pdfView;
+- (void)PDFView:(PDFView *)pdfView editAnnotation:(PDFAnnotation *)annotation;
+- (void)PDFView:(PDFView *)pdfView showSnapshotAtPageNumber:(NSInteger)pageNum
forRect:(NSRect)rect scaleFactor:(CGFloat)scaleFactor autoFits:(BOOL)autoFits;
+- (void)PDFViewPerformHideFind:(PDFView *)pdfView;
+- (BOOL)PDFViewIsFindVisible:(PDFView *)pdfView;
+- (void)PDFView:(PDFView *)pdfView didRotatePageAtIndex:(NSUInteger)idx
by:(NSInteger)rotation;
+- (nullable NSUndoManager *)undoManagerForPDFView:(PDFView *)pdfView;
@end
@class SKReadingBar, SKTypeSelectHelper, SKNavigationWindow,
SKCursorStyleWindow, SKTextNoteEditor, SKSyncDot, SKLoupeController,
SKLayerController;
Modified: trunk/SKSnapshotPDFView.h
===================================================================
--- trunk/SKSnapshotPDFView.h 2024-11-27 10:34:31 UTC (rev 14752)
+++ trunk/SKSnapshotPDFView.h 2024-11-27 10:37:14 UTC (rev 14753)
@@ -44,7 +44,7 @@
@protocol SKSnapshotPDFViewDelegate <PDFViewDelegate>
@optional
-- (void)PDFView:(PDFView *)sender goToExternalDestination:(PDFDestination
*)destination;
+- (void)PDFView:(PDFView *)aPDFView goToExternalDestination:(PDFDestination
*)destination;
@end
@interface SKSnapshotPDFView : SKBasePDFView {
Modified: trunk/SKSnapshotWindowController.m
===================================================================
--- trunk/SKSnapshotWindowController.m 2024-11-27 10:34:31 UTC (rev 14752)
+++ trunk/SKSnapshotWindowController.m 2024-11-27 10:37:14 UTC (rev 14753)
@@ -228,7 +228,7 @@
[[self delegate] snapshotControllerDidMove:self];
}
-- (void)PDFView:(PDFView *)sender goToExternalDestination:(PDFDestination
*)destination {
+- (void)PDFView:(PDFView *)aPDFView goToExternalDestination:(PDFDestination
*)destination {
if ([[self delegate]
respondsToSelector:@selector(snapshotController:goToDestination:)])
[[self delegate] snapshotController:self goToDestination:destination];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
