Revision: 14784
http://sourceforge.net/p/skim-app/code/14784
Author: hofman
Date: 2024-12-08 14:55:50 +0000 (Sun, 08 Dec 2024)
Log Message:
-----------
No need to redraw alternate pdfviews when annotations change, they aren't drawn
on the pdf image
Modified Paths:
--------------
trunk/SKMainWindowController.m
trunk/SKSnapshotWindowController.h
trunk/SKSnapshotWindowController.m
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2024-12-08 14:51:25 UTC (rev 14783)
+++ trunk/SKMainWindowController.m 2024-12-08 14:55:50 UTC (rev 14784)
@@ -2700,8 +2700,6 @@
if ([wc isPageVisible:[note page]]) {
[self snapshotNeedsUpdate:wc placeholder:NO];
[wc setNeedsDisplayForAnnotation:note onPage:page];
- if (NSIsEmptyRect(oldRect) == NO)
- [wc setNeedsDisplayInRect:oldRect ofPage:page];
}
}
@@ -2713,7 +2711,6 @@
oldRect = NSInsetRect(oldRect, -margin, -margin);
}
[pdfView setNeedsDisplayInRect:oldRect ofPage:page];
- [secondaryPdfView setNeedsDisplayInRect:oldRect
ofPage:page];
}
if ([keyPath isEqualToString:SKNPDFAnnotationBoundsKey]) {
Modified: trunk/SKSnapshotWindowController.h
===================================================================
--- trunk/SKSnapshotWindowController.h 2024-12-08 14:51:25 UTC (rev 14783)
+++ trunk/SKSnapshotWindowController.h 2024-12-08 14:55:50 UTC (rev 14784)
@@ -104,7 +104,6 @@
- (void)handleDidRemoveAnnotationNotification:(NSNotification *)notification;
- (void)handleDidMoveAnnotationNotification:(NSNotification *)notification;
-- (void)setNeedsDisplayInRect:(NSRect)rect ofPage:(PDFPage *)page;
- (void)setNeedsDisplayForAnnotation:(PDFAnnotation *)annotation
onPage:(nullable PDFPage *)page;
@end
Modified: trunk/SKSnapshotWindowController.m
===================================================================
--- trunk/SKSnapshotWindowController.m 2024-12-08 14:51:25 UTC (rev 14783)
+++ trunk/SKSnapshotWindowController.m 2024-12-08 14:55:50 UTC (rev 14784)
@@ -130,10 +130,6 @@
return [displayName stringByAppendingEmDashAndString:[NSString
stringWithFormat:NSLocalizedString(@"Page %@", @""), [self pageLabel]]];
}
-- (void)setNeedsDisplayInRect:(NSRect)rect ofPage:(PDFPage *)page {
- [pdfView setNeedsDisplayInRect:rect ofPage:page];
-}
-
- (void)setNeedsDisplayForAnnotation:(PDFAnnotation *)annotation
onPage:(PDFPage *)page {
[pdfView setNeedsDisplayForAnnotation:annotation onPage:page];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit