[Skim-app-commit] SF.net SVN: skim-app:[14844] trunk

[hofman--- via Skim-app-commit]

Revision: 14844
          http://sourceforge.net/p/skim-app/code/14844
Author:   hofman
Date:     2024-12-18 22:28:34 +0000 (Wed, 18 Dec 2024)
Log Message:
-----------
remove rowheight by setting to zero

Modified Paths:
--------------
    trunk/SKMainWindowController.m
    trunk/SKMainWindowController_UI.m
    trunk/SKNoteOutlineView.h
    trunk/SKNoteOutlineView.m
    trunk/SKNotesDocument.m

Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m      2024-12-18 17:43:52 UTC (rev 14843)
+++ trunk/SKMainWindowController.m      2024-12-18 22:28:34 UTC (rev 14844)
@@ -1336,8 +1336,8 @@
     [[self windowControllerForNote:note] close];
     
     if ([note hasNoteText])
-        [rightSideController.noteOutlineView removeRowHeightForItem:[note 
noteText]];
-    [rightSideController.noteOutlineView removeRowHeightForItem:note];
+        [rightSideController.noteOutlineView setRowHeight:0.0 forItem:[note 
noteText]];
+    [rightSideController.noteOutlineView setRowHeight:0.0 forItem:note];
     
     // Stop observing the removed notes
     [self stopObservingNotes:@[note]];
@@ -2708,9 +2708,9 @@
             
             if (mwcFlags.autoResizeNoteRows) {
                 if ([keyPath isEqualToString:SKNPDFAnnotationStringKey])
-                    [rightSideController.noteOutlineView 
removeRowHeightForItem:note];
+                    [rightSideController.noteOutlineView setRowHeight:0.0 
forItem:note];
                 else if ([keyPath isEqualToString:SKNPDFAnnotationTextKey])
-                    [rightSideController.noteOutlineView 
removeRowHeightForItem:[note noteText]];
+                    [rightSideController.noteOutlineView setRowHeight:0.0 
forItem:[note noteText]];
             }
             if ([self notesNeedReloadForKey:keyPath]) {
                 [self performSelectorOnce:@selector(reloadNotesTable) 
afterDelay:0.0];

Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m   2024-12-18 17:43:52 UTC (rev 14843)
+++ trunk/SKMainWindowController_UI.m   2024-12-18 22:28:34 UTC (rev 14844)
@@ -1188,7 +1188,7 @@
         SKNoteOutlineView *ov = rightSideController.noteOutlineView;
         NSMutableIndexSet *indexes = [NSMutableIndexSet indexSet];
         for (id item in items) {
-            [rightSideController.noteOutlineView removeRowHeightForItem:item];
+            [rightSideController.noteOutlineView setRowHeight:0.0 
forItem:item];
             NSInteger row = [ov rowForItem:item];
             if (row != -1)
                 [indexes addIndex:row];

Modified: trunk/SKNoteOutlineView.h
===================================================================
--- trunk/SKNoteOutlineView.h   2024-12-18 17:43:52 UTC (rev 14843)
+++ trunk/SKNoteOutlineView.h   2024-12-18 22:28:34 UTC (rev 14844)
@@ -61,7 +61,6 @@
 
 - (CGFloat)rowHeightForItem:(id)item;
 - (void)setRowHeight:(CGFloat)rowHeight forItem:(id)item;
-- (void)removeRowHeightForItem:(id)item;
 - (void)resetRowHeights;
 
 @end

Modified: trunk/SKNoteOutlineView.m
===================================================================
--- trunk/SKNoteOutlineView.m   2024-12-18 17:43:52 UTC (rev 14843)
+++ trunk/SKNoteOutlineView.m   2024-12-18 22:28:34 UTC (rev 14844)
@@ -108,13 +108,12 @@
 }
 
 - (void)setRowHeight:(CGFloat)rowHeight forItem:(id)item {
-    NSMapInsert(rowHeights, (__bridge void *)item, (void 
*)(NSInteger)rowHeight);
+    if (rowHeight > 0.0)
+        NSMapInsert(rowHeights, (__bridge void *)item, (void 
*)(NSInteger)rowHeight);
+    else
+        NSMapRemove(rowHeights, (__bridge void *)item);
 }
 
-- (void)removeRowHeightForItem:(id)item {
-    NSMapRemove(rowHeights, (__bridge void *)item);
-}
-
 - (void)resetRowHeights {
     [rowHeights removeAllObjects];
 }

Modified: trunk/SKNotesDocument.m
===================================================================
--- trunk/SKNotesDocument.m     2024-12-18 17:43:52 UTC (rev 14843)
+++ trunk/SKNotesDocument.m     2024-12-18 22:28:34 UTC (rev 14844)
@@ -587,7 +587,7 @@
     } else {
         NSMutableIndexSet *indexes = [NSMutableIndexSet indexSet];
         for (id item in items) {
-            [outlineView removeRowHeightForItem:item];
+            [outlineView setRowHeight:0.0 forItem:item];
             NSInteger row = [outlineView rowForItem:item];
             if (row != -1)
                 [indexes addIndex:row];

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit