[Skim-app-commit] SF.net SVN: skim-app:[14921] trunk

[hofman--- via Skim-app-commit]

Revision: 14921
          http://sourceforge.net/p/skim-app/code/14921
Author:   hofman
Date:     2025-02-08 17:34:01 +0000 (Sat, 08 Feb 2025)
Log Message:
-----------
fall back to validateUserIntefaceItem: when validateMenuItem: is not 
implemented in the superclass

Modified Paths:
--------------
    trunk/SKNotesDocument.m
    trunk/SKOutlineView.m
    trunk/SKOverviewView.m
    trunk/SKPDFView.m
    trunk/SKTableView.m

Modified: trunk/SKNotesDocument.m
===================================================================
--- trunk/SKNotesDocument.m     2025-02-08 16:40:55 UTC (rev 14920)
+++ trunk/SKNotesDocument.m     2025-02-08 17:34:01 UTC (rev 14921)
@@ -656,6 +656,8 @@
             default:
                 return NO;
         }
+    } else if ([[SKNotesDocument superclass] instancesRespondToSelector:_cmd]) 
{
+        return [super validateMenuItem:menuItem];
     }
     return YES;
 }

Modified: trunk/SKOutlineView.m
===================================================================
--- trunk/SKOutlineView.m       2025-02-08 16:40:55 UTC (rev 14920)
+++ trunk/SKOutlineView.m       2025-02-08 17:34:01 UTC (rev 14921)
@@ -218,6 +218,8 @@
         return [self allowsEmptySelection];
     else if ([[SKOutlineView superclass] 
instancesRespondToSelector:@selector(validateMenuItem:)])
         return [super validateMenuItem:menuItem];
+    else if ([self respondsToSelector:@selector(validateUserInterfaceItem:)])
+        return [self validateUserInterfaceItem:menuItem];
     return YES;
 }
 

Modified: trunk/SKOverviewView.m
===================================================================
--- trunk/SKOverviewView.m      2025-02-08 16:40:55 UTC (rev 14920)
+++ trunk/SKOverviewView.m      2025-02-08 17:34:01 UTC (rev 14921)
@@ -42,6 +42,10 @@
 #import "SKApplication.h"
 
 
+@interface NSCollectionView (SKPrivateDeclarations)
+- (BOOL)validateUserInterfaceItem:(id)item;
+@end
+
 @implementation SKOverviewView
 
 @synthesize singleClickAction, doubleClickAction, typeSelectHelper;
@@ -90,6 +94,8 @@
         return YES;
     } else if ([[SKOverviewView superclass] instancesRespondToSelector:_cmd]) {
         return [super validateMenuItem:menuItem];
+    } else if ([self 
respondsToSelector:@selector(validateUserInterfaceItem:)]) {
+        return [self validateUserInterfaceItem:menuItem];
     } else {
         return YES;
     }

Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m   2025-02-08 16:40:55 UTC (rev 14920)
+++ trunk/SKPDFView.m   2025-02-08 17:34:01 UTC (rev 14921)
@@ -3251,8 +3251,10 @@
         return toolMode == SKToolModeNote;
     } else if (action == @selector(moveReadingBar:) || action == 
@selector(resizeReadingBar:)) {
         return [self hasReadingBar];
+    } else if ([[SKPDFView superclass] instancesRespondToSelector:_cmd]) {
+        return [super validateMenuItem:menuItem];
     } else {
-        return [super validateMenuItem:menuItem];
+        return YES;
     }
 }
 

Modified: trunk/SKTableView.m
===================================================================
--- trunk/SKTableView.m 2025-02-08 16:40:55 UTC (rev 14920)
+++ trunk/SKTableView.m 2025-02-08 17:34:01 UTC (rev 14921)
@@ -213,6 +213,8 @@
         return [self allowsEmptySelection];
     else if ([[SKTableView superclass] 
instancesRespondToSelector:@selector(validateMenuItem:)])
         return [super validateMenuItem:menuItem];
+    else if ([self respondsToSelector:@selector(validateUserInterfaceItem:)])
+        return [self validateUserInterfaceItem:menuItem];
     return YES;
 }
 

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit