Revision: 15278
http://sourceforge.net/p/skim-app/code/15278
Author: hofman
Date: 2025-05-24 21:49:45 +0000 (Sat, 24 May 2025)
Log Message:
-----------
create side view controllers in code, no need for IBOutlet properties
Modified Paths:
--------------
trunk/MainWindow.xib
trunk/SKMainWindowController.h
trunk/SKMainWindowController.m
Modified: trunk/MainWindow.xib
===================================================================
--- trunk/MainWindow.xib 2025-05-24 20:34:56 UTC (rev 15277)
+++ trunk/MainWindow.xib 2025-05-24 21:49:45 UTC (rev 15278)
@@ -11,12 +11,10 @@
<outlet property="centerContentView" destination="1321"
id="1526"/>
<outlet property="findBarTopConstraint"
destination="Twe-rt-5Qm" id="9jp-xi-0gz"/>
<outlet property="leftSideContentView" destination="769"
id="774"/>
- <outlet property="leftSideController" destination="1543"
id="1545"/>
<outlet property="mainWindow" destination="5" id="1554"/>
<outlet property="pdfContentView" destination="1315"
id="1527"/>
<outlet property="pdfSplitView" destination="1314" id="1318"/>
<outlet property="rightSideContentView" destination="770"
id="775"/>
- <outlet property="rightSideController" destination="1544"
id="1546"/>
<outlet property="splitView" destination="1385" id="1448"/>
<outlet property="statusBar" destination="2Zw-iS-Qai"
id="5oD-6z-7iD"/>
<outlet property="topConstraint" destination="kue-s7-oZq"
id="Tun-Zg-UFY"/>
@@ -107,15 +105,5 @@
</connections>
<point key="canvasLocation" x="139" y="147"/>
</window>
- <customObject id="1543" customClass="SKLeftSideViewController">
- <connections>
- <outlet property="mainController" destination="-2" id="1547"/>
- </connections>
- </customObject>
- <customObject id="1544" customClass="SKRightSideViewController">
- <connections>
- <outlet property="mainController" destination="-2" id="1548"/>
- </connections>
- </customObject>
</objects>
</document>
Modified: trunk/SKMainWindowController.h
===================================================================
--- trunk/SKMainWindowController.h 2025-05-24 20:34:56 UTC (rev 15277)
+++ trunk/SKMainWindowController.h 2025-05-24 21:49:45 UTC (rev 15278)
@@ -218,9 +218,6 @@
@property (nonatomic, nullable, strong) IBOutlet NSLayoutConstraint
*findBarTopConstraint;
@property (nonatomic, nullable, strong) IBOutlet SKStatusBar *statusBar;
-
-@property (nonatomic, nullable, strong) IBOutlet SKLeftSideViewController
*leftSideController;
-@property (nonatomic, nullable, strong) IBOutlet SKRightSideViewController
*rightSideController;
@property (nonatomic, nullable, strong) IBOutlet NSView *leftSideContentView,
*rightSideContentView;
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2025-05-24 20:34:56 UTC (rev 15277)
+++ trunk/SKMainWindowController.m 2025-05-24 21:49:45 UTC (rev 15278)
@@ -218,7 +218,7 @@
@implementation SKMainWindowController
-@synthesize mainWindow, splitView, topConstraint, centerContentView,
pdfSplitView, pdfContentView, findBarTopConstraint, statusBar, pdfView,
secondaryPdfView, leftSideController, rightSideController, leftSideContentView,
rightSideContentView, presentationNotesDocument, presentationNotesOffset,
notes, thumbnails, snapshots, searchResults, groupedSearchResults, tags,
rating, pageLabel, interactionMode, placeholderPdfDocument;
+@synthesize mainWindow, splitView, topConstraint, centerContentView,
pdfSplitView, pdfContentView, findBarTopConstraint, statusBar, pdfView,
secondaryPdfView, leftSideContentView, rightSideContentView,
presentationNotesDocument, presentationNotesOffset, notes, thumbnails,
snapshots, searchResults, groupedSearchResults, tags, rating, pageLabel,
interactionMode, placeholderPdfDocument;
@dynamic pdfDocument, presentationUndoManager, selectedNotes, hasNotes,
widgetProperties, currentPage, leftSidePaneState, rightSidePaneState,
findPaneState, displaysFindPane, leftSidePaneIsOpen, rightSidePaneIsOpen,
searchString, hasNoteToolbar, hasOverview, notesMenu;
+ (BOOL)automaticallyNotifiesObserversOfPageLabel { return NO; }
@@ -305,6 +305,11 @@
// Set up the panes and subviews, needs to be done before we resize them
+ leftSideController = [[SKLeftSideViewController alloc] init];
+ [leftSideController setMainController:self];
+ rightSideController = [[SKRightSideViewController alloc] init];
+ [rightSideController setMainController:self];
+
// make sure the first thing we call on the side view controllers is its
view so their nib is loaded
[leftSideContentView addSubviewWithConstraints:leftSideController.view];
[rightSideContentView addSubviewWithConstraints:rightSideController.view];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit