Revision: 15389
http://sourceforge.net/p/skim-app/code/15389
Author: hofman
Date: 2025-06-06 14:20:56 +0000 (Fri, 06 Jun 2025)
Log Message:
-----------
initialize line rects for markup notes in class factory method
Modified Paths:
--------------
trunk/PDFAnnotation_SKExtensions.m
trunk/SKMainWindowController.m
Modified: trunk/PDFAnnotation_SKExtensions.m
===================================================================
--- trunk/PDFAnnotation_SKExtensions.m 2025-06-06 14:14:13 UTC (rev 15388)
+++ trunk/PDFAnnotation_SKExtensions.m 2025-06-06 14:20:56 UTC (rev 15389)
@@ -139,7 +139,11 @@
}
+ (PDFAnnotation *)newSkimNoteWithProperties:(NSDictionary *)dict {
- return [[SKAnnotationClassForType([dict
objectForKey:SKNPDFAnnotationTypeKey]) alloc] initSkimNoteWithProperties:dict];
+ PDFAnnotation *annotation = [[SKAnnotationClassForType([dict
objectForKey:SKNPDFAnnotationTypeKey]) alloc] initSkimNoteWithProperties:dict];
+ // this is only to make sure markup annotations generate the lineRects,
for thread safety
+ if ([annotation isMarkup])
+ [annotation boundsOrder];
+ return annotation;
}
+ (PDFAnnotation *)newSkimNoteWithSelection:(PDFSelection *)selection
forType:(NSString *)type {
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2025-06-06 14:14:13 UTC (rev 15388)
+++ trunk/SKMainWindowController.m 2025-06-06 14:20:56 UTC (rev 15389)
@@ -980,9 +980,6 @@
@autoreleasepool{
PDFAnnotation *annotation = [PDFAnnotation
newSkimNoteWithProperties:dict];
if (annotation) {
- // this is only to make sure markup annotations generate the
lineRects, for thread safety
- if ([annotation isMarkup])
- [annotation boundsOrder];
NSUInteger pageIndex = [[dict
objectForKey:SKNPDFAnnotationPageIndexKey] unsignedIntegerValue];
if (pageIndex == NSNotFound)
pageIndex = 0;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
