[Skim-app-commit] SF.net SVN: skim-app:[15425] trunk/SKMainWindowContro ller.m

[hofman--- via Skim-app-commit]

Revision: 15425
          http://sourceforge.net/p/skim-app/code/15425
Author:   hofman
Date:     2025-06-10 16:09:58 +0000 (Tue, 10 Jun 2025)
Log Message:
-----------
return early when no widgets, avoid local variables

Modified Paths:
--------------
    trunk/SKMainWindowController.m

Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m      2025-06-10 16:05:15 UTC (rev 15424)
+++ trunk/SKMainWindowController.m      2025-06-10 16:09:58 UTC (rev 15425)
@@ -944,14 +944,12 @@
 - (NSArray *)widgetProperties {
     if (placeholderWidgetProperties)
         return placeholderWidgetProperties;
+    if ([widgets count] == 0)
+        return @[];
     NSMutableArray *properties = [NSMutableArray array];
-    if (widgets) {
-        for (PDFAnnotation *widget in widgets) {
-            id value = [widget objectValue];
-            id origValue = [widgetValues objectForKey:widget];
-            if ([(value ?: @"") isEqual:(origValue ?: @"")] == NO)
-                [properties addObject:[widget SkimNoteProperties]];
-        }
+    for (PDFAnnotation *widget in widgets) {
+        if ([([widget objectValue] ?: @"") isEqual:([widgetValues 
objectForKey:widget] ?: @"")] == NO)
+            [properties addObject:[widget SkimNoteProperties]];
     }
     return properties;
 }

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit