[Skim-app-commit] SF.net SVN: skim-app:[15454] trunk/SKMainWindowContro ller.m

[hofman--- via Skim-app-commit]

Revision: 15454
          http://sourceforge.net/p/skim-app/code/15454
Author:   hofman
Date:     2025-06-13 15:52:48 +0000 (Fri, 13 Jun 2025)
Log Message:
-----------
autoreleasepool in loop should be overkill with ARM

Modified Paths:
--------------
    trunk/SKMainWindowController.m

Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m      2025-06-13 09:14:36 UTC (rev 15453)
+++ trunk/SKMainWindowController.m      2025-06-13 15:52:48 UTC (rev 15454)
@@ -1032,19 +1032,17 @@
         if ([[dict objectForKey:SKNPDFAnnotationTypeKey] 
isEqualToString:SKNWidgetString]) {
             [widgetDicts addObject:dict];
         } else {
-            @autoreleasepool{
-                PDFAnnotation *annotation = [PDFAnnotation 
newSkimNoteWithProperties:dict];
-                if (annotation) {
-                    NSUInteger pageIndex = [[dict 
objectForKey:SKNPDFAnnotationPageIndexKey] unsignedIntegerValue];
-                    if (pageIndex == NSNotFound)
-                        pageIndex = 0;
-                    else if (pageIndex >= [pdfDoc pageCount])
-                        pageIndex = [pdfDoc pageCount] - 1;
-                    PDFPage *page = [pdfDoc pageAtIndex:pageIndex];
-                    if (autoUpdate && [[annotation contents] length] == 0)
-                        [annotation autoUpdateStringWithPage:page];
-                    [notesAndPagesToAdd addObject:@[annotation, page]];
-                }
+            PDFAnnotation *annotation = [PDFAnnotation 
newSkimNoteWithProperties:dict];
+            if (annotation) {
+                NSUInteger pageIndex = [[dict 
objectForKey:SKNPDFAnnotationPageIndexKey] unsignedIntegerValue];
+                if (pageIndex == NSNotFound)
+                    pageIndex = 0;
+                else if (pageIndex >= [pdfDoc pageCount])
+                    pageIndex = [pdfDoc pageCount] - 1;
+                PDFPage *page = [pdfDoc pageAtIndex:pageIndex];
+                if (autoUpdate && [[annotation contents] length] == 0)
+                    [annotation autoUpdateStringWithPage:page];
+                [notesAndPagesToAdd addObject:@[annotation, page]];
             }
         }
     }

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit