Revision: 15457 http://sourceforge.net/p/skim-app/code/15457 Author: hofman Date: 2025-06-14 14:32:45 +0000 (Sat, 14 Jun 2025) Log Message: ----------- remove updateMinMaxScale method as e noww enforce a maximum of 20. Fix maximum value in formatter.
Modified Paths: -------------- trunk/MainToolbar.xib trunk/SKMainToolbarController.h trunk/SKMainToolbarController.m trunk/SKMainWindowController.m Modified: trunk/MainToolbar.xib =================================================================== --- trunk/MainToolbar.xib 2025-06-13 17:21:27 UTC (rev 15456) +++ trunk/MainToolbar.xib 2025-06-14 14:32:45 UTC (rev 15457) @@ -538,7 +538,7 @@ <numberFormatter key="formatter" formatterBehavior="default10_4" numberStyle="percent" usesGroupingSeparator="NO" lenient="YES" formatWidth="-1" minimumIntegerDigits="1" maximumIntegerDigits="2000000000" decimalSeparator="." groupingSeparator="," id="44"> <integer key="multiplier" value="100"/> <real key="minimum" value="0.10000000000000001"/> - <real key="maximum" value="2000"/> + <real key="maximum" value="20"/> </numberFormatter> <font key="font" metaFont="system"/> <color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/> Modified: trunk/SKMainToolbarController.h =================================================================== --- trunk/SKMainToolbarController.h 2025-06-13 17:21:27 UTC (rev 15456) +++ trunk/SKMainToolbarController.h 2025-06-14 14:32:45 UTC (rev 15457) @@ -109,8 +109,6 @@ - (void)noteToolbarDidShowOrHide; -- (void)updateMinMaxScale; - #pragma mark Actions - (IBAction)goToPreviousNextFirstLastPage:(nullable id)sender; Modified: trunk/SKMainToolbarController.m =================================================================== --- trunk/SKMainToolbarController.m 2025-06-13 17:21:27 UTC (rev 15456) +++ trunk/SKMainToolbarController.m 2025-06-14 14:32:45 UTC (rev 15457) @@ -329,8 +329,6 @@ [item setView:scaleField]; [item setMenuFormRepresentation:menuItem]; - [self updateMinMaxScale]; - } else if ([identifier isEqualToString:SKDocumentToolbarZoomActualItemIdentifier]) { menuItem = [[NSMenuItem alloc] initWithTitle:NSLocalizedString(@"Actual Size", @"Menu item title") action:@selector(zoomActualPhysical:) target:self]; @@ -1114,11 +1112,6 @@ } } -- (void)updateMinMaxScale { - [(NSNumberFormatter *)[scaleField formatter] setMinimum:[NSNumber numberWithDouble:[mainController.pdfView minScaleFactor]]]; - [(NSNumberFormatter *)[scaleField formatter] setMaximum:[NSNumber numberWithDouble:[mainController.pdfView maxScaleFactor]]]; -} - - (void)noteToolbarDidShowOrHide { [notesButton setSelected:[mainController hasNoteToolbar] forSegment:0]; NSToolbarItem *item = [toolbarItems objectForKey:SKDocumentToolbarNotesItemIdentifier]; Modified: trunk/SKMainWindowController.m =================================================================== --- trunk/SKMainWindowController.m 2025-06-13 17:21:27 UTC (rev 15456) +++ trunk/SKMainWindowController.m 2025-06-14 14:32:45 UTC (rev 15457) @@ -1199,8 +1199,6 @@ [self registerForDocumentNotifications]; - [toolbarController updateMinMaxScale]; - if (unlocked) [self updateWidgetsWithProperties:widgetProperties reset:NO]; else if ([widgetProperties count]) This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. _______________________________________________ Skim-app-commit mailing list Skim-app-commit@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/skim-app-commit