[Skim-app-commit] SF.net SVN: skim-app:[15464] trunk/SKMainWindowContro ller.m

[hofman--- via Skim-app-commit]

Revision: 15464
          http://sourceforge.net/p/skim-app/code/15464
Author:   hofman
Date:     2025-06-15 14:20:49 +0000 (Sun, 15 Jun 2025)
Log Message:
-----------
Reuse variables, no need to update pdfview for notes

Modified Paths:
--------------
    trunk/SKMainWindowController.m

Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m      2025-06-15 14:13:10 UTC (rev 15463)
+++ trunk/SKMainWindowController.m      2025-06-15 14:20:49 UTC (rev 15464)
@@ -2131,21 +2131,20 @@
 
 - (void)documentDidUnlock:(NSNotification *)notification {
     BOOL wasLocked = [[savedNormalSetup objectForKey:LOCKED_KEY] boolValue];
+    PDFDocument *pdfDoc = [pdfView document];
     
-    if (placeholderPdfDocument && [[self pdfDocument] allowsNotes]) {
-        PDFDocument *pdfDoc = [self pdfDocument];
-        NSMutableIndexSet *pageIndexes = [NSMutableIndexSet indexSet];
+    if (placeholderPdfDocument && [pdfDoc allowsNotes]) {
+        NSMutableIndexSet *pageIndexes = wasLocked ? nil : [NSMutableIndexSet 
indexSet];
         for (PDFAnnotation *note in [self notes]) {
             PDFPage *page = [note page];
-            NSUInteger pageIndex = [page pageIndex];
             if ([page document] != pdfDoc) {
+                NSUInteger pageIndex = [page pageIndex];
                 [page removeAnnotation:note];
-                [[pdfDoc pageAtIndex:[page pageIndex]] addAnnotation:note];
+                [[pdfDoc pageAtIndex:pageIndex] addAnnotation:note];
                 [pageIndexes addIndex:pageIndex];
             }
         }
         placeholderPdfDocument = nil;
-        [pdfView setNeedsDisplay:YES];
         [rightSideController.noteArrayController rearrangeObjects];
         if (wasLocked == NO) {
             [rightSideController.noteOutlineView reloadData];

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit